From 6fa4305abafe6ab0564381d4dd15c9139a009b29 Mon Sep 17 00:00:00 2001 From: Chocobo1 Date: Wed, 5 Oct 2022 00:59:18 +0800 Subject: [PATCH] Fix wrong 'tracker error' count This happens when a torrent contains some tracker URLs that share the same domain. Closes #17808. --- src/gui/transferlistfilterswidget.cpp | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/gui/transferlistfilterswidget.cpp b/src/gui/transferlistfilterswidget.cpp index 8bfefe9ed..448217cfa 100644 --- a/src/gui/transferlistfilterswidget.cpp +++ b/src/gui/transferlistfilterswidget.cpp @@ -70,11 +70,14 @@ namespace return !scheme.isEmpty() ? scheme : u"http"_qs; } - QString getHost(const QString &tracker) + QString getHost(const QString &url) { // We want the domain + tld. Subdomains should be disregarded - const QUrl url {tracker}; - const QString host {url.host()}; + // If failed to parse the domain or IP address, original input should be returned + + const QString host = QUrl(url).host(); + if (host.isEmpty()) + return url; // host is in IP format if (!QHostAddress(host).isNull()) @@ -505,10 +508,8 @@ void TrackerFiltersList::addItems(const QString &trackerURL, const QVector torrentIDs = m_trackers.value(host).torrents; - if (torrentIDs.empty()) - return; + QSet torrentIDs = m_trackers.value(host).torrents; torrentIDs.remove(id); QListWidgetItem *trackerItem = nullptr;