Reduce number of DownloadManager signals

src/base/bittorrent/session.cpp

@@ -1542,22 +1542,21 @@ void Session::processShareLimits()
     }
 }
 
-void Session::handleDownloadFailed(const QString &url, const QString &reason)
-{
-    emit downloadFromUrlFailed(url, reason);
-}
-
-void Session::handleRedirectedToMagnet(const QString &url, const QString &magnetUri)
-{
-    addTorrent_impl(CreateTorrentParams(m_downloadedTorrents.take(url)), MagnetUri(magnetUri));
-}
-
 // Add to BitTorrent session the downloaded torrent file
-void Session::handleDownloadFinished(const QString &url, const QByteArray &data)
+void Session::handleDownloadFinished(const Net::DownloadResult &result)
 {
-    emit downloadFromUrlFinished(url);
+    switch (result.status) {
-    addTorrent_impl(CreateTorrentParams(m_downloadedTorrents.take(url))
+    case Net::DownloadStatus::Success:
-                    , MagnetUri(), TorrentInfo::load(data));
+        emit downloadFromUrlFinished(result.url);
+        addTorrent_impl(CreateTorrentParams(m_downloadedTorrents.take(result.url))
+                        , MagnetUri(), TorrentInfo::load(result.data));
+        break;
+    case Net::DownloadStatus::RedirectedToMagnet:
+        addTorrent_impl(CreateTorrentParams(m_downloadedTorrents.take(result.url)), MagnetUri(result.magnet));
+        break;
+    default:
+        emit downloadFromUrlFailed(result.url, result.errorString);
+    }
 }
 
 // Return the torrent handle, given its hash
@@ -1796,11 +1795,8 @@ bool Session::addTorrent(const QString &source, const AddTorrentParams &params)
         LogMsg(tr("Downloading '%1', please wait...", "e.g: Downloading 'xxx.torrent', please wait...").arg(source));
         // Launch downloader
         const Net::DownloadHandler *handler =
-                Net::DownloadManager::instance()->download(Net::DownloadRequest(source).limit(10485760 /* 10MB */).handleRedirectToMagnet(true));
+                Net::DownloadManager::instance()->download(Net::DownloadRequest(source).limit(10485760 /* 10MB */));
-        connect(handler, static_cast<void (Net::DownloadHandler::*)(const QString &, const QByteArray &)>(&Net::DownloadHandler::downloadFinished)
+        connect(handler, &Net::DownloadHandler::finished, this, &Session::handleDownloadFinished);
-                , this, &Session::handleDownloadFinished);
-        connect(handler, &Net::DownloadHandler::downloadFailed, this, &Session::handleDownloadFailed);
-        connect(handler, &Net::DownloadHandler::redirectedToMagnet, this, &Session::handleRedirectedToMagnet);
         m_downloadedTorrents[handler->url()] = params;
         return true;
     }

src/base/bittorrent/session.h

@@ -118,6 +118,11 @@ enum TorrentExportFolder
     Finished
 };
 
+namespace Net
+{
+    struct DownloadResult;
+}
+
 namespace BitTorrent
 {
     class InfoHash;
@@ -537,9 +542,7 @@ namespace BitTorrent
         void generateResumeData(bool final = false);
         void handleIPFilterParsed(int ruleCount);
         void handleIPFilterError();
-        void handleDownloadFinished(const QString &url, const QByteArray &data);
+        void handleDownloadFinished(const Net::DownloadResult &result);
-        void handleDownloadFailed(const QString &url, const QString &reason);
-        void handleRedirectedToMagnet(const QString &url, const QString &magnetUri);
 
         // Session reconfiguration triggers
         void networkOnlineStateChanged(bool online);

src/base/net/dnsupdater.cpp

@@ -76,19 +76,20 @@ void DNSUpdater::checkPublicIP()
 
     DownloadHandler *handler = DownloadManager::instance()->download(
                 DownloadRequest("http://checkip.dyndns.org").userAgent("qBittorrent/" QBT_VERSION_2));
-    connect(handler, static_cast<void (Net::DownloadHandler::*)(const QString &, const QByteArray &)>(&Net::DownloadHandler::downloadFinished)
+    connect(handler, &DownloadHandler::finished, this, &DNSUpdater::ipRequestFinished);
-            , this, &DNSUpdater::ipRequestFinished);
-    connect(handler, &Net::DownloadHandler::downloadFailed, this, &DNSUpdater::ipRequestFailed);
 
     m_lastIPCheckTime = QDateTime::currentDateTime();
 }
 
-void DNSUpdater::ipRequestFinished(const QString &url, const QByteArray &data)
+void DNSUpdater::ipRequestFinished(const DownloadResult &result)
 {
-    Q_UNUSED(url);
+    if (result.status != DownloadStatus::Success) {
+        qWarning() << "IP request failed:" << result.errorString;
+        return;
+    }
 
     // Parse response
-    const QRegularExpressionMatch ipRegexMatch = QRegularExpression("Current IP Address:\\s+([^<]+)</body>").match(data);
+    const QRegularExpressionMatch ipRegexMatch = QRegularExpression("Current IP Address:\\s+([^<]+)</body>").match(result.data);
     if (ipRegexMatch.hasMatch()) {
         QString ipStr = ipRegexMatch.captured(1);
         qDebug() << Q_FUNC_INFO << "Regular expression captured the following IP:" << ipStr;
@@ -110,12 +111,6 @@ void DNSUpdater::ipRequestFinished(const QString &url, const QByteArray &data)
     }
 }
 
-void DNSUpdater::ipRequestFailed(const QString &url, const QString &error)
-{
-    Q_UNUSED(url);
-    qWarning() << "IP request failed:" << error;
-}
-
 void DNSUpdater::updateDNSService()
 {
     qDebug() << Q_FUNC_INFO;
@@ -123,9 +118,7 @@ void DNSUpdater::updateDNSService()
     m_lastIPCheckTime = QDateTime::currentDateTime();
     DownloadHandler *handler = DownloadManager::instance()->download(
                 DownloadRequest(getUpdateUrl()).userAgent("qBittorrent/" QBT_VERSION_2));
-    connect(handler, static_cast<void (Net::DownloadHandler::*)(const QString &, const QByteArray &)>(&Net::DownloadHandler::downloadFinished)
+    connect(handler, &DownloadHandler::finished, this, &DNSUpdater::ipUpdateFinished);
-            , this, &DNSUpdater::ipUpdateFinished);
-    connect(handler, &Net::DownloadHandler::downloadFailed, this, &DNSUpdater::ipUpdateFailed);
 }
 
 QString DNSUpdater::getUpdateUrl() const
@@ -164,17 +157,12 @@ QString DNSUpdater::getUpdateUrl() const
     return url.toString();
 }
 
-void DNSUpdater::ipUpdateFinished(const QString &url, const QByteArray &data)
+void DNSUpdater::ipUpdateFinished(const DownloadResult &result)
-{
-    Q_UNUSED(url);
-    // Parse reply
-    processIPUpdateReply(data);
-}
-
-void DNSUpdater::ipUpdateFailed(const QString &url, const QString &error)
 {
-    Q_UNUSED(url);
+    if (result.status == DownloadStatus::Success)
-    qWarning() << "IP update failed:" << error;
+        processIPUpdateReply(result.data);
+    else
+        qWarning() << "IP update failed:" << result.errorString;
 }
 
 void DNSUpdater::processIPUpdateReply(const QString &reply)

src/base/net/dnsupdater.h

@@ -38,6 +38,8 @@
 
 namespace Net
 {
+    struct DownloadResult;
+
     // Based on http://www.dyndns.com/developers/specs/
     class DNSUpdater : public QObject
     {
@@ -54,11 +56,9 @@ namespace Net
 
     private slots:
         void checkPublicIP();
-        void ipRequestFinished(const QString &url, const QByteArray &data);
+        void ipRequestFinished(const DownloadResult &result);
-        void ipRequestFailed(const QString &url, const QString &error);
         void updateDNSService();
-        void ipUpdateFinished(const QString &url, const QByteArray &data);
+        void ipUpdateFinished(const DownloadResult &result);
-        void ipUpdateFailed(const QString &url, const QString &error);
 
     private:
         enum State

src/base/net/downloadhandler.cpp

@@ -69,6 +69,8 @@ Net::DownloadHandler::DownloadHandler(QNetworkReply *reply, DownloadManager *man
 {
     if (reply)
         assignNetworkReply(reply);
+    m_result.url = url();
+    m_result.status = DownloadStatus::Success;
 }
 
 Net::DownloadHandler::~DownloadHandler()
@@ -103,8 +105,8 @@ void Net::DownloadHandler::processFinishedDownload()
     if (m_reply->error() != QNetworkReply::NoError) {
         // Failure
         qDebug("Download failure (%s), reason: %s", qUtf8Printable(url), qUtf8Printable(errorCodeToString(m_reply->error())));
-        emit downloadFailed(m_downloadRequest.url(), errorCodeToString(m_reply->error()));
+        setError(errorCodeToString(m_reply->error()));
-        this->deleteLater();
+        finish();
         return;
     }
 
@@ -117,49 +119,43 @@ void Net::DownloadHandler::processFinishedDownload()
     }
 
     // Success
-    const QByteArray replyData = (m_reply->rawHeader("Content-Encoding") == "gzip")
+    m_result.data = (m_reply->rawHeader("Content-Encoding") == "gzip")
         ? Utils::Gzip::decompress(m_reply->readAll())
         : m_reply->readAll();
 
     if (m_downloadRequest.saveToFile()) {
         QString filePath;
-        if (saveToFile(replyData, filePath))
+        if (saveToFile(m_result.data, filePath))
-            emit downloadFinished(m_downloadRequest.url(), filePath);
+            m_result.filePath = filePath;
         else
-            emit downloadFailed(m_downloadRequest.url(), tr("I/O Error"));
+            setError(tr("I/O Error"));
-    }
-    else {
-        emit downloadFinished(m_downloadRequest.url(), replyData);
     }
 
-    this->deleteLater();
+    finish();
 }
 
 void Net::DownloadHandler::checkDownloadSize(const qint64 bytesReceived, const qint64 bytesTotal)
 {
-    QString msg = tr("The file size is %1. It exceeds the download limit of %2.");
+    if ((bytesTotal > 0) && (bytesTotal <= m_downloadRequest.limit())) {
-
-    if (bytesTotal > 0) {
         // Total number of bytes is available
-        if (bytesTotal > m_downloadRequest.limit()) {
+        disconnect(m_reply, &QNetworkReply::downloadProgress, this, &Net::DownloadHandler::checkDownloadSize);
-            m_reply->abort();
+        return;
-            emit downloadFailed(m_downloadRequest.url(), msg.arg(Utils::Misc::friendlyUnit(bytesTotal), Utils::Misc::friendlyUnit(m_downloadRequest.limit())));
-        }
-        else {
-            disconnect(m_reply, &QNetworkReply::downloadProgress, this, &Net::DownloadHandler::checkDownloadSize);
-        }
     }
-    else if (bytesReceived > m_downloadRequest.limit()) {
+
+    if ((bytesTotal > m_downloadRequest.limit()) || (bytesReceived > m_downloadRequest.limit())) {
         m_reply->abort();
-        emit downloadFailed(m_downloadRequest.url(), msg.arg(Utils::Misc::friendlyUnit(bytesReceived), Utils::Misc::friendlyUnit(m_downloadRequest.limit())));
+        setError(tr("The file size is %1. It exceeds the download limit of %2.")
+                 .arg(Utils::Misc::friendlyUnit(bytesTotal)
+                      , Utils::Misc::friendlyUnit(m_downloadRequest.limit())));
+        finish();
     }
 }
 
 void Net::DownloadHandler::handleRedirection(const QUrl &newUrl)
 {
     if (m_redirectionCounter >= MAX_REDIRECTIONS) {
-        emit downloadFailed(url(), tr("Exceeded max redirections (%1)").arg(MAX_REDIRECTIONS));
+        setError(tr("Exceeded max redirections (%1)").arg(MAX_REDIRECTIONS));
-        this->deleteLater();
+        finish();
         return;
     }
 
@@ -172,38 +168,35 @@ void Net::DownloadHandler::handleRedirection(const QUrl &newUrl)
     if (newUrlString.startsWith("magnet:", Qt::CaseInsensitive)) {
         qDebug("Magnet redirect detected.");
         m_reply->abort();
-        if (m_downloadRequest.handleRedirectToMagnet())
+        m_result.status = DownloadStatus::RedirectedToMagnet;
-            emit redirectedToMagnet(m_downloadRequest.url(), newUrlString);
+        m_result.magnet = newUrlString;
-        else
-            emit downloadFailed(m_downloadRequest.url(), tr("Unexpected redirect to magnet URI."));
 
-        this->deleteLater();
+        finish();
         return;
     }
 
     DownloadHandler *redirected = m_manager->download(DownloadRequest(m_downloadRequest).url(newUrlString));
     redirected->m_redirectionCounter = (m_redirectionCounter + 1);
-    connect(redirected, &DownloadHandler::destroyed, this, &DownloadHandler::deleteLater);
+    connect(redirected, &DownloadHandler::finished, this, [this](const DownloadResult &result)
-    connect(redirected, &DownloadHandler::downloadFailed, this, [this](const QString &, const QString &reason)
-    {
-        emit downloadFailed(url(), reason);
-    });
-    connect(redirected, &DownloadHandler::redirectedToMagnet, this, [this](const QString &, const QString &magnetUri)
-    {
-        emit redirectedToMagnet(url(), magnetUri);
-    });
-    connect(redirected, static_cast<void (DownloadHandler::*)(const QString &, const QString &)>(&DownloadHandler::downloadFinished)
-            , this, [this](const QString &, const QString &fileName)
     {
-        emit downloadFinished(url(), fileName);
+        m_result = result;
-    });
+        m_result.url = url();
-    connect(redirected, static_cast<void (DownloadHandler::*)(const QString &, const QByteArray &)>(&DownloadHandler::downloadFinished)
+        finish();
-            , this, [this](const QString &, const QByteArray &data)
-    {
-        emit downloadFinished(url(), data);
     });
 }
 
+void Net::DownloadHandler::setError(const QString &error)
+{
+    m_result.errorString = error;
+    m_result.status = DownloadStatus::Failed;
+}
+
+void Net::DownloadHandler::finish()
+{
+    emit finished(m_result);
+    deleteLater();
+}
+
 QString Net::DownloadHandler::errorCodeToString(const QNetworkReply::NetworkError status)
 {
     switch (status) {

src/base/net/downloadhandler.h

@@ -56,10 +56,7 @@ namespace Net
         QString url() const;
 
     signals:
-        void downloadFinished(const QString &url, const QByteArray &data);
+        void finished(const DownloadResult &result);
-        void downloadFinished(const QString &url, const QString &filePath);
-        void downloadFailed(const QString &url, const QString &reason);
-        void redirectedToMagnet(const QString &url, const QString &magnetUri);
 
     private slots:
         void processFinishedDownload();
@@ -68,6 +65,8 @@ namespace Net
     private:
         void assignNetworkReply(QNetworkReply *reply);
         void handleRedirection(const QUrl &newUrl);
+        void setError(const QString &error);
+        void finish();
 
         static QString errorCodeToString(QNetworkReply::NetworkError status);
 
@@ -75,6 +74,7 @@ namespace Net
         DownloadManager *m_manager;
         const DownloadRequest m_downloadRequest;
         short m_redirectionCounter = 0;
+        DownloadResult m_result;
     };
 }
 

src/base/net/downloadmanager.cpp

@@ -328,17 +328,6 @@ Net::DownloadRequest &Net::DownloadRequest::saveToFile(const bool value)
     return *this;
 }
 
-bool Net::DownloadRequest::handleRedirectToMagnet() const
-{
-    return m_handleRedirectToMagnet;
-}
-
-Net::DownloadRequest &Net::DownloadRequest::handleRedirectToMagnet(const bool value)
-{
-    m_handleRedirectToMagnet = value;
-    return *this;
-}
-
 Net::ServiceID Net::ServiceID::fromURL(const QUrl &url)
 {
     return {url.host(), url.port(80)};

src/base/net/downloadmanager.h

@@ -64,15 +64,28 @@ namespace Net
         bool saveToFile() const;
         DownloadRequest &saveToFile(bool value);
 
-        bool handleRedirectToMagnet() const;
-        DownloadRequest &handleRedirectToMagnet(bool value);
-
     private:
         QString m_url;
         QString m_userAgent;
         qint64 m_limit = 0;
         bool m_saveToFile = false;
-        bool m_handleRedirectToMagnet = false;
+    };
+
+    enum class DownloadStatus
+    {
+        Success,
+        RedirectedToMagnet,
+        Failed
+    };
+
+    struct DownloadResult
+    {
+        QString url;
+        DownloadStatus status;
+        QString errorString;
+        QByteArray data;
+        QString filePath;
+        QString magnet;
     };
 
     struct ServiceID

src/base/net/geoipmanager.cpp

@@ -119,9 +119,7 @@ void GeoIPManager::manageDatabaseUpdate()
 void GeoIPManager::downloadDatabaseFile()
 {
     const DownloadHandler *handler = DownloadManager::instance()->download({DATABASE_URL});
-    connect(handler, static_cast<void (Net::DownloadHandler::*)(const QString &, const QByteArray &)>(&Net::DownloadHandler::downloadFinished)
+    connect(handler, &DownloadHandler::finished, this, &GeoIPManager::downloadFinished);
-            , this, &GeoIPManager::downloadFinished);
-    connect(handler, &Net::DownloadHandler::downloadFailed, this, &GeoIPManager::downloadFailed);
 }
 
 QString GeoIPManager::lookup(const QHostAddress &hostAddr) const
@@ -413,14 +411,17 @@ void GeoIPManager::configure()
     }
 }
 
-void GeoIPManager::downloadFinished(const QString &url, QByteArray data)
+void GeoIPManager::downloadFinished(const DownloadResult &result)
 {
-    Q_UNUSED(url);
+    if (result.status != DownloadStatus::Success) {
+        LogMsg(tr("Couldn't download GeoIP database file. Reason: %1").arg(result.errorString), Log::WARNING);
+        return;
+    }
 
     bool ok = false;
-    data = Utils::Gzip::decompress(data, &ok);
+    const QByteArray data = Utils::Gzip::decompress(result.data, &ok);
     if (!ok) {
-        Logger::instance()->addMessage(tr("Could not decompress GeoIP database file."), Log::WARNING);
+        LogMsg(tr("Could not decompress GeoIP database file."), Log::WARNING);
         return;
     }
 
@@ -431,7 +432,7 @@ void GeoIPManager::downloadFinished(const QString &url, QByteArray data)
             if (m_geoIPDatabase)
                 delete m_geoIPDatabase;
             m_geoIPDatabase = geoIPDatabase;
-            Logger::instance()->addMessage(tr("GeoIP database loaded. Type: %1. Build time: %2.")
+            LogMsg(tr("GeoIP database loaded. Type: %1. Build time: %2.")
                 .arg(m_geoIPDatabase->type(), m_geoIPDatabase->buildEpoch().toString()),
                 Log::INFO);
             const QString targetPath = Utils::Fs::expandPathAbs(
@@ -439,25 +440,16 @@ void GeoIPManager::downloadFinished(const QString &url, QByteArray data)
             if (!QDir(targetPath).exists())
                 QDir().mkpath(targetPath);
             QFile targetFile(QString("%1/%2").arg(targetPath, GEOIP_FILENAME));
-            if (!targetFile.open(QFile::WriteOnly) || (targetFile.write(data) == -1)) {
+            if (!targetFile.open(QFile::WriteOnly) || (targetFile.write(data) == -1))
-                Logger::instance()->addMessage(
+                LogMsg(tr("Couldn't save downloaded GeoIP database file."), Log::WARNING);
-                            tr("Couldn't save downloaded GeoIP database file."), Log::WARNING);
+            else
-            }
+                LogMsg(tr("Successfully updated GeoIP database."), Log::INFO);
-            else {
-                Logger::instance()->addMessage(tr("Successfully updated GeoIP database."), Log::INFO);
-            }
         }
         else {
             delete geoIPDatabase;
         }
     }
     else {
-        Logger::instance()->addMessage(tr("Couldn't load GeoIP database. Reason: %1").arg(error), Log::WARNING);
+        LogMsg(tr("Couldn't load GeoIP database. Reason: %1").arg(error), Log::WARNING);
     }
 }
-
-void GeoIPManager::downloadFailed(const QString &url, const QString &reason)
-{
-    Q_UNUSED(url);
-    Logger::instance()->addMessage(tr("Couldn't download GeoIP database file. Reason: %1").arg(reason), Log::WARNING);
-}

src/base/net/geoipmanager.h

@@ -40,9 +40,12 @@ class GeoIPDatabase;
 
 namespace Net
 {
+    struct DownloadResult;
+
     class GeoIPManager : public QObject
     {
         Q_OBJECT
+        Q_DISABLE_COPY(GeoIPManager)
 
     public:
         static void initInstance();
@@ -55,12 +58,11 @@ namespace Net
 
     private slots:
         void configure();
-        void downloadFinished(const QString &url, QByteArray data);
+        void downloadFinished(const DownloadResult &result);
-        void downloadFailed(const QString &url, const QString &reason);
 
     private:
         GeoIPManager();
-        ~GeoIPManager();
+        ~GeoIPManager() override;
 
         void loadDatabase();
         void manageDatabaseUpdate();

src/base/rss/rss_feed.cpp

@@ -131,10 +131,7 @@ void Feed::refresh()
     // NOTE: Should we allow manually refreshing for disabled session?
 
     Net::DownloadHandler *handler = Net::DownloadManager::instance()->download(m_url);
-    connect(handler
+    connect(handler, &Net::DownloadHandler::finished, this, &Feed::handleDownloadFinished);
-            , static_cast<void (Net::DownloadHandler::*)(const QString &, const QByteArray &)>(&Net::DownloadHandler::downloadFinished)
-            , this, &Feed::handleDownloadFinished);
-    connect(handler, &Net::DownloadHandler::downloadFailed, this, &Feed::handleDownloadFailed);
 
     m_isLoading = true;
     emit stateChanged(this);
@@ -182,12 +179,12 @@ void Feed::handleMaxArticlesPerFeedChanged(const int n)
     // We don't need store articles here
 }
 
-void Feed::handleIconDownloadFinished(const QString &url, const QString &filePath)
+void Feed::handleIconDownloadFinished(const Net::DownloadResult &result)
 {
-    Q_UNUSED(url);
+    if (result.status == Net::DownloadStatus::Success) {
-
+        m_iconPath = Utils::Fs::fromNativePath(result.filePath);
-    m_iconPath = Utils::Fs::fromNativePath(filePath);
+        emit iconLoaded(this);
-    emit iconLoaded(this);
+    }
 }
 
 bool Feed::hasError() const
@@ -195,22 +192,22 @@ bool Feed::hasError() const
     return m_hasError;
 }
 
-void Feed::handleDownloadFinished(const QString &url, const QByteArray &data)
+void Feed::handleDownloadFinished(const Net::DownloadResult &result)
-{
-    qDebug() << "Successfully downloaded RSS feed at" << url;
-    // Parse the download RSS
-    m_parser->parse(data);
-}
-
-void Feed::handleDownloadFailed(const QString &url, const QString &error)
 {
-    m_isLoading = false;
+    if (result.status == Net::DownloadStatus::Success) {
-    m_hasError = true;
+        qDebug() << "Successfully downloaded RSS feed at" << result.url;
+        // Parse the download RSS
+        m_parser->parse(result.data);
+    }
+    else {
+        m_isLoading = false;
+        m_hasError = true;
 
-    LogMsg(tr("Failed to download RSS feed at '%1'. Reason: %2").arg(url, error)
+        LogMsg(tr("Failed to download RSS feed at '%1'. Reason: %2")
-           , Log::WARNING);
+               .arg(result.url, result.errorString), Log::WARNING);
 
-    emit stateChanged(this);
+        emit stateChanged(this);
+    }
 }
 
 void Feed::handleParsingFinished(const RSS::Private::ParsingResult &result)
@@ -404,9 +401,7 @@ void Feed::downloadIcon()
     const auto iconUrl = QString("%1://%2/favicon.ico").arg(url.scheme(), url.host());
     const Net::DownloadHandler *handler = Net::DownloadManager::instance()->download(
             Net::DownloadRequest(iconUrl).saveToFile(true));
-    connect(handler
+    connect(handler, &Net::DownloadHandler::finished, this, &Feed::handleIconDownloadFinished);
-            , static_cast<void (Net::DownloadHandler::*)(const QString &, const QString &)>(&Net::DownloadHandler::downloadFinished)
-            , this, &Feed::handleIconDownloadFinished);
 }
 
 int Feed::updateArticles(const QList<QVariantHash> &loadedArticles)

src/base/rss/rss_feed.h

@@ -39,6 +39,11 @@
 
 class AsyncFileStorage;
 
+namespace Net
+{
+    struct DownloadResult;
+}
+
 namespace RSS
 {
     class Article;
@@ -85,9 +90,8 @@ namespace RSS
     private slots:
         void handleSessionProcessingEnabledChanged(bool enabled);
         void handleMaxArticlesPerFeedChanged(int n);
-        void handleIconDownloadFinished(const QString &url, const QString &filePath);
+        void handleIconDownloadFinished(const Net::DownloadResult &result);
-        void handleDownloadFinished(const QString &url, const QByteArray &data);
+        void handleDownloadFinished(const Net::DownloadResult &result);
-        void handleDownloadFailed(const QString &url, const QString &error);
         void handleParsingFinished(const Private::ParsingResult &result);
         void handleArticleRead(Article *article);
 

src/base/search/searchpluginmanager.cpp

@@ -200,9 +200,7 @@ void SearchPluginManager::installPlugin(const QString &source)
     if (Net::DownloadManager::hasSupportedScheme(source)) {
         using namespace Net;
         DownloadHandler *handler = DownloadManager::instance()->download(DownloadRequest(source).saveToFile(true));
-        connect(handler, static_cast<void (DownloadHandler::*)(const QString &, const QString &)>(&DownloadHandler::downloadFinished)
+        connect(handler, &Net::DownloadHandler::finished, this, &SearchPluginManager::pluginDownloadFinished);
-                , this, &SearchPluginManager::pluginDownloaded);
-        connect(handler, &DownloadHandler::downloadFailed, this, &SearchPluginManager::pluginDownloadFailed);
     }
     else {
         QString path = source;
@@ -305,9 +303,7 @@ void SearchPluginManager::checkForUpdates()
     // Download version file from update server
     using namespace Net;
     DownloadHandler *handler = DownloadManager::instance()->download({m_updateUrl + "versions.txt"});
-    connect(handler, static_cast<void (DownloadHandler::*)(const QString &, const QByteArray &)>(&DownloadHandler::downloadFinished)
+    connect(handler, &Net::DownloadHandler::finished, this, &SearchPluginManager::versionInfoDownloadFinished);
-            , this, &SearchPluginManager::versionInfoDownloaded);
-    connect(handler, &DownloadHandler::downloadFailed, this, &SearchPluginManager::versionInfoDownloadFailed);
 }
 
 SearchDownloadHandler *SearchPluginManager::downloadTorrent(const QString &siteUrl, const QString &url)
@@ -364,36 +360,32 @@ QString SearchPluginManager::engineLocation()
     return location;
 }
 
-void SearchPluginManager::versionInfoDownloaded(const QString &url, const QByteArray &data)
+void SearchPluginManager::versionInfoDownloadFinished(const Net::DownloadResult &result)
 {
-    Q_UNUSED(url)
+    if (result.status == Net::DownloadStatus::Success)
-    parseVersionInfo(data);
+        parseVersionInfo(result.data);
-}
+    else
-
+        emit checkForUpdatesFailed(tr("Update server is temporarily unavailable. %1").arg(result.errorString));
-void SearchPluginManager::versionInfoDownloadFailed(const QString &url, const QString &reason)
-{
-    Q_UNUSED(url)
-    emit checkForUpdatesFailed(tr("Update server is temporarily unavailable. %1").arg(reason));
 }
 
-void SearchPluginManager::pluginDownloaded(const QString &url, QString filePath)
+void SearchPluginManager::pluginDownloadFinished(const Net::DownloadResult &result)
 {
-    filePath = Utils::Fs::fromNativePath(filePath);
+    if (result.status == Net::DownloadStatus::Success) {
-
+        const QString filePath = Utils::Fs::fromNativePath(result.filePath);
-    QString pluginName = Utils::Fs::fileName(url);
-    pluginName.chop(pluginName.size() - pluginName.lastIndexOf('.')); // Remove extension
-    installPlugin_impl(pluginName, filePath);
-    Utils::Fs::forceRemove(filePath);
-}
 
-void SearchPluginManager::pluginDownloadFailed(const QString &url, const QString &reason)
+        QString pluginName = Utils::Fs::fileName(result.url);
-{
+        pluginName.chop(pluginName.size() - pluginName.lastIndexOf('.')); // Remove extension
-    QString pluginName = url.split('/').last();
+        installPlugin_impl(pluginName, filePath);
-    pluginName.replace(".py", "", Qt::CaseInsensitive);
+        Utils::Fs::forceRemove(filePath);
-    if (pluginInfo(pluginName))
+    }
-        emit pluginUpdateFailed(pluginName, tr("Failed to download the plugin file. %1").arg(reason));
+    else {
-    else
+        QString pluginName = result.url.split('/').last();
-        emit pluginInstallationFailed(pluginName, tr("Failed to download the plugin file. %1").arg(reason));
+        pluginName.replace(".py", "", Qt::CaseInsensitive);
+        if (pluginInfo(pluginName))
+            emit pluginUpdateFailed(pluginName, tr("Failed to download the plugin file. %1").arg(result.errorString));
+        else
+            emit pluginInstallationFailed(pluginName, tr("Failed to download the plugin file. %1").arg(result.errorString));
+    }
 }
 
 // Update nova.py search plugin if necessary

src/base/search/searchpluginmanager.h

@@ -38,6 +38,11 @@
 using PluginVersion = Utils::Version<unsigned short, 2>;
 Q_DECLARE_METATYPE(PluginVersion)
 
+namespace Net
+{
+    struct DownloadResult;
+}
+
 struct PluginInfo
 {
     QString name;
@@ -104,10 +109,8 @@ private:
     void installPlugin_impl(const QString &name, const QString &path);
     bool isUpdateNeeded(const QString &pluginName, PluginVersion newVersion) const;
 
-    void versionInfoDownloaded(const QString &url, const QByteArray &data);
+    void versionInfoDownloadFinished(const Net::DownloadResult &result);
-    void versionInfoDownloadFailed(const QString &url, const QString &reason);
+    void pluginDownloadFinished(const Net::DownloadResult &result);
-    void pluginDownloaded(const QString &url, QString filePath);
-    void pluginDownloadFailed(const QString &url, const QString &reason);
 
     static QString pluginPath(const QString &name);
 

src/gui/addnewtorrentdialog.cpp

@@ -238,11 +238,8 @@ void AddNewTorrentDialog::show(const QString &source, const BitTorrent::AddTorre
     if (Net::DownloadManager::hasSupportedScheme(source)) {
         // Launch downloader
         Net::DownloadHandler *handler = Net::DownloadManager::instance()->download(
-                Net::DownloadRequest(source).limit(10485760 /* 10MB */).handleRedirectToMagnet(true));
+                Net::DownloadRequest(source).limit(10485760 /* 10MB */));
-        connect(handler, static_cast<void (Net::DownloadHandler::*)(const QString &, const QByteArray &)>(&Net::DownloadHandler::downloadFinished)
+        connect(handler, &Net::DownloadHandler::finished, dlg, &AddNewTorrentDialog::handleDownloadFinished);
-                , dlg, &AddNewTorrentDialog::handleDownloadFinished);
-        connect(handler, &Net::DownloadHandler::downloadFailed, dlg, &AddNewTorrentDialog::handleDownloadFailed);
-        connect(handler, &Net::DownloadHandler::redirectedToMagnet, dlg, &AddNewTorrentDialog::handleRedirectedToMagnet);
         return;
     }
 
@@ -761,39 +758,36 @@ void AddNewTorrentDialog::setupTreeview()
     showAdvancedSettings(settings()->loadValue(KEY_EXPANDED, false).toBool());
 }
 
-void AddNewTorrentDialog::handleDownloadFailed(const QString &url, const QString &reason)
+void AddNewTorrentDialog::handleDownloadFinished(const Net::DownloadResult &result)
-{
-    RaisedMessageBox::critical(this, tr("Download Error"),
-        QString("Cannot download '%1': %2").arg(url, reason));
-    this->deleteLater();
-}
-
-void AddNewTorrentDialog::handleRedirectedToMagnet(const QString &url, const QString &magnetUri)
-{
-    Q_UNUSED(url)
-
-    if (loadMagnet(BitTorrent::MagnetUri(magnetUri)))
-        open();
-    else
-        this->deleteLater();
-}
-
-void AddNewTorrentDialog::handleDownloadFinished(const QString &url, const QByteArray &data)
 {
     QString error;
-    m_torrentInfo = BitTorrent::TorrentInfo::load(data, &error);
+    switch (result.status) {
-    if (!m_torrentInfo.isValid()) {
+    case Net::DownloadStatus::Success:
-        RaisedMessageBox::critical(this, tr("Invalid torrent"), tr("Failed to load from URL: %1.\nError: %2")
+        m_torrentInfo = BitTorrent::TorrentInfo::load(result.data, &error);
-            .arg(url, error));
+        if (!m_torrentInfo.isValid()) {
-        return;
+            RaisedMessageBox::critical(this, tr("Invalid torrent"), tr("Failed to load from URL: %1.\nError: %2")
-    }
+                                       .arg(result.url, error));
-
+            return;
-    m_torrentGuard.reset(new TorrentFileGuard);
+        }
 
-    if (loadTorrentImpl())
+        m_torrentGuard.reset(new TorrentFileGuard);
-        open();
+
-    else
+        if (loadTorrentImpl())
-        this->deleteLater();
+            open();
+        else
+            deleteLater();
+        break;
+    case Net::DownloadStatus::RedirectedToMagnet:
+        if (loadMagnet(BitTorrent::MagnetUri(result.magnet)))
+            open();
+        else
+            deleteLater();
+        break;
+    default:
+        RaisedMessageBox::critical(this, tr("Download Error"),
+            tr("Cannot download '%1': %2").arg(result.url, result.errorString));
+        deleteLater();
+    }
 }
 
 void AddNewTorrentDialog::TMMChanged(int index)

src/gui/addnewtorrentdialog.h

@@ -43,6 +43,11 @@ namespace BitTorrent
     class MagnetUri;
 }
 
+namespace Net
+{
+    struct DownloadResult;
+}
+
 namespace Ui
 {
     class AddNewTorrentDialog;
@@ -55,12 +60,13 @@ class TorrentFileGuard;
 class AddNewTorrentDialog : public QDialog
 {
     Q_OBJECT
+    Q_DISABLE_COPY(AddNewTorrentDialog)
 
 public:
     static const int minPathHistoryLength = 0;
     static const int maxPathHistoryLength = 99;
 
-    ~AddNewTorrentDialog();
+    ~AddNewTorrentDialog() override;
 
     static bool isEnabled();
     static void setEnabled(bool value);
@@ -79,9 +85,7 @@ private slots:
     void onSavePathChanged(const QString &newPath);
     void renameSelectedFile();
     void updateMetadata(const BitTorrent::TorrentInfo &info);
-    void handleDownloadFailed(const QString &url, const QString &reason);
+    void handleDownloadFinished(const Net::DownloadResult &result);
-    void handleRedirectedToMagnet(const QString &url, const QString &magnetUri);
-    void handleDownloadFinished(const QString &url, const QByteArray &data);
     void TMMChanged(int index);
     void categoryChanged(int index);
     void doNotDeleteTorrentClicked(bool checked);

src/gui/mainwindow.cpp

@@ -2020,26 +2020,31 @@ void MainWindow::installPython()
                                   : "https://www.python.org/ftp/python/3.4.4/python-3.4.4.msi");
     Net::DownloadHandler *handler = Net::DownloadManager::instance()->download(
                                         Net::DownloadRequest(installerURL).saveToFile(true));
-
+    connect(handler, &Net::DownloadHandler::finished, this, &MainWindow::pythonDownloadFinished);
-    using Func = void (Net::DownloadHandler::*)(const QString &, const QString &);
-    connect(handler, static_cast<Func>(&Net::DownloadHandler::downloadFinished), this, &MainWindow::pythonDownloadSuccess);
-    connect(handler, static_cast<Func>(&Net::DownloadHandler::downloadFailed), this, &MainWindow::pythonDownloadFailure);
 }
 
-void MainWindow::pythonDownloadSuccess(const QString &url, const QString &filePath)
+void MainWindow::pythonDownloadFinished(const Net::DownloadResult &result)
 {
-    Q_UNUSED(url)
+    if (result.status != Net::DownloadStatus::Success) {
+        setCursor(QCursor(Qt::ArrowCursor));
+        QMessageBox::warning(
+                    this, tr("Download error")
+                    , tr("Python setup could not be downloaded, reason: %1.\nPlease install it manually.")
+                    .arg(result.errorString));
+        return;
+    }
+
     setCursor(QCursor(Qt::ArrowCursor));
     QProcess installer;
     qDebug("Launching Python installer in passive mode...");
 
     if (QSysInfo::windowsVersion() >= QSysInfo::WV_VISTA) {
-        QFile::rename(filePath, filePath + ".exe");
+        QFile::rename(result.filePath, result.filePath + ".exe");
-        installer.start('"' + Utils::Fs::toNativePath(filePath) + ".exe\" /passive");
+        installer.start('"' + Utils::Fs::toNativePath(result.filePath) + ".exe\" /passive");
     }
     else {
-        QFile::rename(filePath, filePath + ".msi");
+        QFile::rename(result.filePath, result.filePath + ".msi");
-        installer.start(Utils::Misc::windowsSystemPath() + "\\msiexec.exe /passive /i \"" + Utils::Fs::toNativePath(filePath) + ".msi\"");
+        installer.start(Utils::Misc::windowsSystemPath() + "\\msiexec.exe /passive /i \"" + Utils::Fs::toNativePath(result.filePath) + ".msi\"");
     }
 
     // Wait for setup to complete
@@ -2050,21 +2055,13 @@ void MainWindow::pythonDownloadSuccess(const QString &url, const QString &filePa
     qDebug("Setup should be complete!");
     // Delete temp file
     if (QSysInfo::windowsVersion() >= QSysInfo::WV_VISTA)
-        Utils::Fs::forceRemove(filePath + ".exe");
+        Utils::Fs::forceRemove(result.filePath + ".exe");
     else
-        Utils::Fs::forceRemove(filePath + ".msi");
+        Utils::Fs::forceRemove(result.filePath + ".msi");
     // Reload search engine
     if (Utils::ForeignApps::pythonInfo().isSupportedVersion()) {
         m_ui->actionSearchWidget->setChecked(true);
         displaySearchTab(true);
     }
 }
-
-void MainWindow::pythonDownloadFailure(const QString &url, const QString &error)
-{
-    Q_UNUSED(url)
-    setCursor(QCursor(Qt::ArrowCursor));
-    QMessageBox::warning(this, tr("Download error"), tr("Python setup could not be downloaded, reason: %1.\nPlease install it manually.").arg(error));
-}
-
 #endif // Q_OS_WIN

src/gui/mainwindow.h

@@ -62,6 +62,11 @@ namespace BitTorrent
     class TorrentHandle;
 }
 
+namespace Net
+{
+    struct DownloadResult;
+}
+
 namespace Ui
 {
     class MainWindow;
@@ -135,8 +140,7 @@ private slots:
     void toggleAlternativeSpeeds();
 
 #ifdef Q_OS_WIN
-    void pythonDownloadSuccess(const QString &url, const QString &filePath);
+    void pythonDownloadFinished(const Net::DownloadResult &result);
-    void pythonDownloadFailure(const QString &url, const QString &error);
 #endif
     void addToolbarContextMenu();
     void manageCookies();

src/gui/programupdater.cpp

@@ -58,14 +58,18 @@ void ProgramUpdater::checkForUpdates()
     // the filehost can identify it and contact us.
     Net::DownloadHandler *handler = Net::DownloadManager::instance()->download(
                 Net::DownloadRequest(RSS_URL).userAgent("qBittorrent/" QBT_VERSION_2 " ProgramUpdater (www.qbittorrent.org)"));
-    connect(handler, static_cast<void (Net::DownloadHandler::*)(const QString &, const QByteArray &)>(&Net::DownloadHandler::downloadFinished)
+    connect(handler, &Net::DownloadHandler::finished, this, &ProgramUpdater::rssDownloadFinished);
-            , this, &ProgramUpdater::rssDownloadFinished);
-    connect(handler, &Net::DownloadHandler::downloadFailed, this, &ProgramUpdater::rssDownloadFailed);
 }
 
-void ProgramUpdater::rssDownloadFinished(const QString &url, const QByteArray &data)
+void ProgramUpdater::rssDownloadFinished(const Net::DownloadResult &result)
 {
-    Q_UNUSED(url);
+
+    if (result.status != Net::DownloadStatus::Success) {
+        qDebug() << "Downloading the new qBittorrent updates RSS failed:" << result.errorString;
+        emit updateCheckFinished(false, QString(), m_invokedByUser);
+        return;
+    }
+
     qDebug("Finished downloading the new qBittorrent updates RSS");
 
 #ifdef Q_OS_MAC
@@ -77,7 +81,7 @@ void ProgramUpdater::rssDownloadFinished(const QString &url, const QByteArray &d
 #endif
 
     QString version;
-    QXmlStreamReader xml(data);
+    QXmlStreamReader xml(result.data);
     bool inItem = false;
     QString updateLink;
     QString type;
@@ -118,14 +122,6 @@ void ProgramUpdater::rssDownloadFinished(const QString &url, const QByteArray &d
     emit updateCheckFinished(!m_updateUrl.isEmpty(), version, m_invokedByUser);
 }
 
-void ProgramUpdater::rssDownloadFailed(const QString &url, const QString &error)
-{
-    Q_UNUSED(url);
-
-    qDebug() << "Downloading the new qBittorrent updates RSS failed:" << error;
-    emit updateCheckFinished(false, QString(), m_invokedByUser);
-}
-
 void ProgramUpdater::updateProgram()
 {
     Q_ASSERT(!m_updateUrl.isEmpty());

src/gui/programupdater.h

@@ -32,9 +32,15 @@
 #include <QObject>
 #include <QUrl>
 
+namespace Net
+{
+    struct DownloadResult;
+}
+
 class ProgramUpdater : public QObject
 {
     Q_OBJECT
+    Q_DISABLE_COPY(ProgramUpdater)
 
 public:
     explicit ProgramUpdater(QObject *parent = nullptr, bool invokedByUser = false);
@@ -46,8 +52,7 @@ signals:
     void updateCheckFinished(bool updateAvailable, QString version, bool invokedByUser);
 
 private slots:
-    void rssDownloadFinished(const QString &url, const QByteArray &data);
+    void rssDownloadFinished(const Net::DownloadResult &result);
-    void rssDownloadFailed(const QString &url, const QString &error);
 
 private:
     bool isVersionMoreRecent(const QString &remoteVersion) const;

src/gui/properties/trackersadditiondialog.cpp

@@ -72,15 +72,24 @@ void TrackersAdditionDialog::on_uTorrentListButton_clicked()
 {
     m_ui->uTorrentListButton->setEnabled(false);
     Net::DownloadHandler *handler = Net::DownloadManager::instance()->download(m_ui->lineEditListURL->text());
-    connect(handler, static_cast<void (Net::DownloadHandler::*)(const QString &, const QByteArray &)>(&Net::DownloadHandler::downloadFinished)
+    connect(handler, &Net::DownloadHandler::finished, this, &TrackersAdditionDialog::torrentListDownloadFinished);
-            , this, &TrackersAdditionDialog::parseUTorrentList);
-    connect(handler, &Net::DownloadHandler::downloadFailed, this, &TrackersAdditionDialog::getTrackerError);
     // Just to show that it takes times
     setCursor(Qt::WaitCursor);
 }
 
-void TrackersAdditionDialog::parseUTorrentList(const QString &, const QByteArray &data)
+void TrackersAdditionDialog::torrentListDownloadFinished(const Net::DownloadResult &result)
 {
+    if (result.status != Net::DownloadStatus::Success) {
+        // To restore the cursor ...
+        setCursor(Qt::ArrowCursor);
+        m_ui->uTorrentListButton->setEnabled(true);
+        QMessageBox::warning(
+                    this, tr("Download error")
+                    , tr("The trackers list could not be downloaded, reason: %1")
+                    .arg(result.errorString), QMessageBox::Ok);
+        return;
+    }
+
     // Load from torrent handle
     QList<BitTorrent::TrackerEntry> existingTrackers = m_torrent->trackers();
     // Load from current user list
@@ -96,7 +105,7 @@ void TrackersAdditionDialog::parseUTorrentList(const QString &, const QByteArray
         m_ui->textEditTrackersList->insertPlainText("\n");
     int nb = 0;
     QBuffer buffer;
-    buffer.setData(data);
+    buffer.setData(result.data);
     buffer.open(QBuffer::ReadOnly);
     while (!buffer.atEnd()) {
         const QString line = buffer.readLine().trimmed();
@@ -117,14 +126,6 @@ void TrackersAdditionDialog::parseUTorrentList(const QString &, const QByteArray
         QMessageBox::information(this, tr("No change"), tr("No additional trackers were found."), QMessageBox::Ok);
 }
 
-void TrackersAdditionDialog::getTrackerError(const QString &, const QString &error)
-{
-    // To restore the cursor ...
-    setCursor(Qt::ArrowCursor);
-    m_ui->uTorrentListButton->setEnabled(true);
-    QMessageBox::warning(this, tr("Download error"), tr("The trackers list could not be downloaded, reason: %1").arg(error), QMessageBox::Ok);
-}
-
 QStringList TrackersAdditionDialog::askForTrackers(QWidget *parent, BitTorrent::TorrentHandle *const torrent)
 {
     QStringList trackers;

src/gui/properties/trackersadditiondialog.h

@@ -39,6 +39,11 @@ namespace BitTorrent
     class TorrentHandle;
 }
 
+namespace Net
+{
+    struct DownloadResult;
+}
+
 namespace Ui
 {
     class TrackersAdditionDialog;
@@ -57,8 +62,7 @@ public:
 
 public slots:
     void on_uTorrentListButton_clicked();
-    void parseUTorrentList(const QString &, const QByteArray &data);
+    void torrentListDownloadFinished(const Net::DownloadResult &result);
-    void getTrackerError(const QString &, const QString &error);
 
 private:
     Ui::TrackersAdditionDialog *m_ui;

src/gui/search/pluginselectdialog.cpp

@@ -293,9 +293,7 @@ void PluginSelectDialog::addNewPlugin(const QString &pluginName)
         using namespace Net;
         DownloadHandler *handler = DownloadManager::instance()->download(
                     DownloadRequest(plugin->url + "/favicon.ico").saveToFile(true));
-        connect(handler, static_cast<void (DownloadHandler::*)(const QString &, const QString &)>(&DownloadHandler::downloadFinished)
+        connect(handler, &DownloadHandler::finished, this, &PluginSelectDialog::iconDownloadFinished);
-                , this, &PluginSelectDialog::iconDownloaded);
-        connect(handler, &DownloadHandler::downloadFailed, this, &PluginSelectDialog::iconDownloadFailed);
     }
     item->setText(PLUGIN_VERSION, plugin->version);
 }
@@ -369,9 +367,14 @@ void PluginSelectDialog::askForLocalPlugin()
     }
 }
 
-void PluginSelectDialog::iconDownloaded(const QString &url, QString filePath)
+void PluginSelectDialog::iconDownloadFinished(const Net::DownloadResult &result)
 {
-    filePath = Utils::Fs::fromNativePath(filePath);
+    if (result.status != Net::DownloadStatus::Success) {
+        qDebug("Could not download favicon: %s, reason: %s", qUtf8Printable(result.url), qUtf8Printable(result.errorString));
+        return;
+    }
+
+    const QString filePath = Utils::Fs::fromNativePath(result.filePath);
 
     // Icon downloaded
     QIcon icon(filePath);
@@ -379,7 +382,7 @@ void PluginSelectDialog::iconDownloaded(const QString &url, QString filePath)
     QList<QSize> sizes = icon.availableSizes();
     bool invalid = (sizes.isEmpty() || icon.pixmap(sizes.first()).isNull());
     if (!invalid) {
-        for (QTreeWidgetItem *item : asConst(findItemsWithUrl(url))) {
+        for (QTreeWidgetItem *item : asConst(findItemsWithUrl(result.url))) {
             QString id = item->text(PLUGIN_ID);
             PluginInfo *plugin = m_pluginManager->pluginInfo(id);
             if (!plugin) continue;
@@ -387,7 +390,7 @@ void PluginSelectDialog::iconDownloaded(const QString &url, QString filePath)
             QString iconPath = QString("%1/%2.%3")
                 .arg(SearchPluginManager::pluginsLocation()
                     , id
-                    , url.endsWith(".ico", Qt::CaseInsensitive) ? "ico" : "png");
+                    , result.url.endsWith(".ico", Qt::CaseInsensitive) ? "ico" : "png");
             if (QFile::copy(filePath, iconPath)) {
                 // This 2nd check is necessary. Some favicons (eg from piratebay)
                 // decode fine without an ext, but fail to do so when appending the ext
@@ -409,11 +412,6 @@ void PluginSelectDialog::iconDownloaded(const QString &url, QString filePath)
     Utils::Fs::forceRemove(filePath);
 }
 
-void PluginSelectDialog::iconDownloadFailed(const QString &url, const QString &reason)
-{
-    qDebug("Could not download favicon: %s, reason: %s", qUtf8Printable(url), qUtf8Printable(reason));
-}
-
 void PluginSelectDialog::checkForUpdatesFinished(const QHash<QString, PluginVersion> &updateInfo)
 {
     finishAsyncOp();

src/gui/search/pluginselectdialog.h

@@ -38,6 +38,11 @@ class QDropEvent;
 class QStringList;
 class QTreeWidgetItem;
 
+namespace Net
+{
+    struct DownloadResult;
+}
+
 namespace Ui
 {
     class PluginSelectDialog;
@@ -46,10 +51,11 @@ namespace Ui
 class PluginSelectDialog : public QDialog
 {
     Q_OBJECT
+    Q_DISABLE_COPY(PluginSelectDialog)
 
 public:
     explicit PluginSelectDialog(SearchPluginManager *pluginManager, QWidget *parent = nullptr);
-    ~PluginSelectDialog();
+    ~PluginSelectDialog() override;
 
     QList<QTreeWidgetItem*> findItemsWithUrl(const QString &url);
     QTreeWidgetItem *findItemWithID(const QString &id);
@@ -69,8 +75,7 @@ private slots:
     void enableSelection(bool enable);
     void askForLocalPlugin();
     void askForPluginUrl();
-    void iconDownloaded(const QString &url, QString filePath);
+    void iconDownloadFinished(const Net::DownloadResult &result);
-    void iconDownloadFailed(const QString &url, const QString &reason);
 
     void checkForUpdatesFinished(const QHash<QString, PluginVersion> &updateInfo);
     void checkForUpdatesFailed(const QString &reason);

src/gui/transferlistfilterswidget.cpp

@@ -408,47 +408,42 @@ void TrackerFiltersList::downloadFavicon(const QString &url)
     if (!m_downloadTrackerFavicon) return;
     Net::DownloadHandler *h = Net::DownloadManager::instance()->download(
                 Net::DownloadRequest(url).saveToFile(true));
-    using Func = void (Net::DownloadHandler::*)(const QString &, const QString &);
+    connect(h, &Net::DownloadHandler::finished, this, &TrackerFiltersList::handleFavicoDownloadFinished);
-    connect(h, static_cast<Func>(&Net::DownloadHandler::downloadFinished), this
-            , &TrackerFiltersList::handleFavicoDownload);
-    connect(h, static_cast<Func>(&Net::DownloadHandler::downloadFailed), this
-            , &TrackerFiltersList::handleFavicoFailure);
 }
 
-void TrackerFiltersList::handleFavicoDownload(const QString &url, const QString &filePath)
+void TrackerFiltersList::handleFavicoDownloadFinished(const Net::DownloadResult &result)
 {
-    const QString host = getHost(url);
+    if (result.status != Net::DownloadStatus::Success) {
+        if (result.url.endsWith(".ico", Qt::CaseInsensitive))
+            downloadFavicon(result.url.left(result.url.size() - 4) + ".png");
+        return;
+    }
+
+    const QString host = getHost(result.url);
 
     if (!m_trackers.contains(host)) {
-        Utils::Fs::forceRemove(filePath);
+        Utils::Fs::forceRemove(result.filePath);
         return;
     }
 
     QListWidgetItem *trackerItem = item(rowFromTracker(host));
     if (!trackerItem) return;
 
-    QIcon icon(filePath);
+    QIcon icon(result.filePath);
     //Detect a non-decodable icon
     QList<QSize> sizes = icon.availableSizes();
     bool invalid = (sizes.isEmpty() || icon.pixmap(sizes.first()).isNull());
     if (invalid) {
-        if (url.endsWith(".ico", Qt::CaseInsensitive))
+        if (result.url.endsWith(".ico", Qt::CaseInsensitive))
-            downloadFavicon(url.left(url.size() - 4) + ".png");
+            downloadFavicon(result.url.left(result.url.size() - 4) + ".png");
-        Utils::Fs::forceRemove(filePath);
+        Utils::Fs::forceRemove(result.filePath);
     }
     else {
-        trackerItem->setData(Qt::DecorationRole, QVariant(QIcon(filePath)));
+        trackerItem->setData(Qt::DecorationRole, QVariant(QIcon(result.filePath)));
-        m_iconPaths.append(filePath);
+        m_iconPaths.append(result.filePath);
     }
 }
 
-void TrackerFiltersList::handleFavicoFailure(const QString &url, const QString &error)
-{
-    Q_UNUSED(error)
-    if (url.endsWith(".ico", Qt::CaseInsensitive))
-        downloadFavicon(url.left(url.size() - 4) + ".png");
-}
-
 void TrackerFiltersList::showMenu(QPoint)
 {
     QMenu menu(this);

src/gui/transferlistfilterswidget.h

@@ -42,9 +42,15 @@ namespace BitTorrent
     class TrackerEntry;
 }
 
+namespace Net
+{
+    struct DownloadResult;
+}
+
 class BaseFilterWidget : public QListWidget
 {
     Q_OBJECT
+    Q_DISABLE_COPY(BaseFilterWidget)
 
 public:
     BaseFilterWidget(QWidget *parent, TransferListWidget *transferList);
@@ -68,6 +74,7 @@ private slots:
 class StatusFilterWidget : public BaseFilterWidget
 {
     Q_OBJECT
+    Q_DISABLE_COPY(StatusFilterWidget)
 
 public:
     StatusFilterWidget(QWidget *parent, TransferListWidget *transferList);
@@ -88,6 +95,7 @@ private:
 class TrackerFiltersList : public BaseFilterWidget
 {
     Q_OBJECT
+    Q_DISABLE_COPY(TrackerFiltersList)
 
 public:
     TrackerFiltersList(QWidget *parent, TransferListWidget *transferList);
@@ -105,8 +113,7 @@ public slots:
     void trackerWarning(const QString &hash, const QString &tracker);
 
 private slots:
-    void handleFavicoDownload(const QString &url, const QString &filePath);
+    void handleFavicoDownloadFinished(const Net::DownloadResult &result);
-    void handleFavicoFailure(const QString &url, const QString &error);
 
 private:
     // These 4 methods are virtual slots in the base class.