Fix coding style (Issue #2192).

src/core/http/connection.h

@@ -42,30 +42,28 @@ QT_END_NAMESPACE
 
 namespace Http
 {
+    class IRequestHandler;
 
-class IRequestHandler;
-
-class Connection : public QObject
-{
+    class Connection : public QObject
+    {
         Q_OBJECT
         Q_DISABLE_COPY(Connection)
 
-public:
+    public:
         Connection(QTcpSocket *socket, IRequestHandler *requestHandler, QObject *parent = 0);
         ~Connection();
 
-private slots:
+    private slots:
         void read();
 
-private:
+    private:
         static bool acceptsGzipEncoding(const QString &encoding);
         void sendResponse(const Response &response);
 
         QTcpSocket *m_socket;
         IRequestHandler *m_requestHandler;
         QByteArray m_receivedData;
-};
-
+    };
 }
 
 #endif // HTTP_CONNECTION_H

src/core/http/irequesthandler.h

@@ -33,14 +33,12 @@
 
 namespace Http
 {
-
-class IRequestHandler
-{
-public:
+    class IRequestHandler
+    {
+    public:
         virtual ~IRequestHandler() {}
         virtual Response processRequest(const Request &request, const Environment &env) = 0;
-};
-
+    };
 }
 
 #endif // HTTP_IREQUESTHANDLER_H

src/core/http/requestparser.h

@@ -36,10 +36,9 @@
 
 namespace Http
 {
-
-class RequestParser
-{
-public:
+    class RequestParser
+    {
+    public:
         enum ErrorCode
         {
             NoError = 0,
@@ -51,7 +50,7 @@ public:
         // Warning! Header names are converted to lower-case.
         static ErrorCode parse(const QByteArray &data, Request &request, uint maxContentLength = 10000000 /* ~10MB */);
 
-private:
+    private:
         RequestParser(uint maxContentLength);
 
         ErrorCode parseHttpRequest(const QByteArray &data, Request &request);
@@ -67,8 +66,7 @@ private:
 
         const uint m_maxContentLength;
         Request m_request;
-};
-
+    };
 }
 
 #endif // HTTP_REQUESTPARSER_H

src/core/http/responsebuilder.h

@@ -34,13 +34,12 @@
 
 namespace Http
 {
-
-class ResponseBuilder : public QObject
-{
-public:
+    class ResponseBuilder : public QObject
+    {
+    public:
         explicit ResponseBuilder(QObject *parent = 0);
 
-protected:
+    protected:
         void status(uint code = 200, const QString &text = QLatin1String("OK"));
         void header(const QString &name, const QString &value);
         void print(const QString &text, const QString &type = CONTENT_TYPE_HTML);
@@ -49,12 +48,11 @@ protected:
 
         Response response() const;
 
-private:
+    private:
         void print_impl(const QByteArray &data, const QString &type);
 
         Response m_response;
-};
-
+    };
 }
 
 #endif // HTTP_RESPONSEBUILDER_H

src/core/http/responsegenerator.h

@@ -37,13 +37,11 @@
 
 namespace Http
 {
-
-class ResponseGenerator
-{
-public:
+    class ResponseGenerator
+    {
+    public:
         static QByteArray generate(Response response);
-};
-
+    };
 }
 
 #endif // HTTP_RESPONSEGENERATOR_H

src/core/http/server.cpp

@@ -38,7 +38,7 @@
 
 using namespace Http;
 
-Server::Server(IRequestHandler *requestHandler, QObject* parent)
+Server::Server(IRequestHandler *requestHandler, QObject *parent)
     : QTcpServer(parent)
     , m_requestHandler(requestHandler)
 #ifndef QT_NO_OPENSSL

src/core/http/server.h

@@ -41,40 +41,38 @@
 
 namespace Http
 {
+    class IRequestHandler;
+    class Connection;
 
-class IRequestHandler;
-class Connection;
-
-class Server : public QTcpServer
-{
+    class Server : public QTcpServer
+    {
         Q_OBJECT
         Q_DISABLE_COPY(Server)
 
-public:
+    public:
         Server(IRequestHandler *requestHandler, QObject *parent = 0);
         ~Server();
 
-#ifndef QT_NO_OPENSSL
+    #ifndef QT_NO_OPENSSL
         void enableHttps(const QSslCertificate &certificate, const QSslKey &key);
         void disableHttps();
-#endif
+    #endif
 
-private:
-#if (QT_VERSION >= QT_VERSION_CHECK(5, 0, 0))
+    private:
+    #if (QT_VERSION >= QT_VERSION_CHECK(5, 0, 0))
         void incomingConnection(qintptr socketDescriptor);
-#else
+    #else
         void incomingConnection(int socketDescriptor);
-#endif
+    #endif
 
-private:
+    private:
         IRequestHandler *m_requestHandler;
-#ifndef QT_NO_OPENSSL
+    #ifndef QT_NO_OPENSSL
         bool m_https;
         QSslCertificate m_certificate;
         QSslKey m_key;
-#endif
-};
-
+    #endif
+    };
 }
 
 #endif // HTTP_SERVER_H

src/core/http/types.h

@@ -37,59 +37,57 @@ typedef QMap<QString, QString> QStringMap;
 
 namespace Http
 {
+    const QString HEADER_SET_COOKIE = "Set-Cookie";
+    const QString HEADER_CONTENT_TYPE = "Content-Type";
+    const QString HEADER_CONTENT_ENCODING = "Content-Encoding";
+    const QString HEADER_CONTENT_LENGTH = "Content-Length";
+    const QString HEADER_CACHE_CONTROL = "Cache-Control";
 
-const QString HEADER_SET_COOKIE = "Set-Cookie";
-const QString HEADER_CONTENT_TYPE = "Content-Type";
-const QString HEADER_CONTENT_ENCODING = "Content-Encoding";
-const QString HEADER_CONTENT_LENGTH = "Content-Length";
-const QString HEADER_CACHE_CONTROL = "Cache-Control";
+    const QString CONTENT_TYPE_CSS = "text/css; charset=UTF-8";
+    const QString CONTENT_TYPE_GIF = "image/gif";
+    const QString CONTENT_TYPE_HTML = "text/html; charset=UTF-8";
+    const QString CONTENT_TYPE_JS = "text/javascript; charset=UTF-8";
+    const QString CONTENT_TYPE_PNG = "image/png";
+    const QString CONTENT_TYPE_TXT = "text/plain; charset=UTF-8";
 
-const QString CONTENT_TYPE_CSS = "text/css; charset=UTF-8";
-const QString CONTENT_TYPE_GIF = "image/gif";
-const QString CONTENT_TYPE_HTML = "text/html; charset=UTF-8";
-const QString CONTENT_TYPE_JS = "text/javascript; charset=UTF-8";
-const QString CONTENT_TYPE_PNG = "image/png";
-const QString CONTENT_TYPE_TXT = "text/plain; charset=UTF-8";
-
-struct Environment
-{
+    struct Environment
+    {
         QHostAddress clientAddress;
-};
+    };
 
-struct UploadedFile
-{
+    struct UploadedFile
+    {
         QString filename; // original filename
         QString type; // MIME type
         QByteArray data; // File data
-};
+    };
 
-struct Request
-{
+    struct Request
+    {
         QString method;
         QString path;
         QStringMap headers;
         QStringMap gets;
         QStringMap posts;
         QMap<QString, UploadedFile> files;
-};
+    };
 
-struct ResponseStatus
-{
+    struct ResponseStatus
+    {
         uint code;
         QString text;
 
         ResponseStatus(uint code = 200, const QString& text = "OK"): code(code), text(text) {}
-};
+    };
 
-struct Response
-{
+    struct Response
+    {
         ResponseStatus status;
         QStringMap headers;
         QByteArray content;
 
         Response(uint code = 200, const QString& text = "OK"): status(code, text) {}
-};
-
+    };
 }
 
 #endif // HTTP_TYPES_H

src/core/net/dnsupdater.cpp

@@ -35,18 +35,21 @@
 #if (QT_VERSION >= QT_VERSION_CHECK(5, 0, 0))
 #include <QUrlQuery>
 #endif
-#include "dnsupdater.h"
+
 #include "core/logger.h"
+#include "dnsupdater.h"
 
 using namespace Net;
 
-DNSUpdater::DNSUpdater(QObject *parent) :
-  QObject(parent), m_state(OK), m_service(DNS::NONE)
+DNSUpdater::DNSUpdater(QObject *parent)
+    : QObject(parent)
+    , m_state(OK)
+    , m_service(DNS::NONE)
 {
     updateCredentials();
 
     // Load saved settings from previous session
-  const Preferences* const pref = Preferences::instance();
+    const Preferences *const pref = Preferences::instance();
     m_lastIPCheckTime = pref->getDNSLastUpd();
     m_lastIP = QHostAddress(pref->getDNSLastIP());
 
@@ -56,15 +59,16 @@ DNSUpdater::DNSUpdater(QObject *parent) :
     m_ipCheckTimer.start();
 
     // Check lastUpdate to avoid flooding
-  if (!m_lastIPCheckTime.isValid() ||
-      m_lastIPCheckTime.secsTo(QDateTime::currentDateTime())*1000 > IP_CHECK_INTERVAL_MS) {
+    if (!m_lastIPCheckTime.isValid()
+        || (m_lastIPCheckTime.secsTo(QDateTime::currentDateTime()) * 1000 > IP_CHECK_INTERVAL_MS)) {
         checkPublicIP();
     }
 }
 
-DNSUpdater::~DNSUpdater() {
+DNSUpdater::~DNSUpdater()
+{
     // Save lastupdate time and last ip
-  Preferences* const pref = Preferences::instance();
+    Preferences *const pref = Preferences::instance();
     pref->setDNSLastUpd(m_lastIPCheckTime);
     pref->setDNSLastIP(m_lastIP.toString());
 }
@@ -73,8 +77,7 @@ void DNSUpdater::checkPublicIP()
 {
     Q_ASSERT(m_state == OK);
     QNetworkAccessManager *manager = new QNetworkAccessManager(this);
-  connect(manager, SIGNAL(finished(QNetworkReply*)),
-          SLOT(ipRequestFinished(QNetworkReply*)));
+    connect(manager, SIGNAL(finished(QNetworkReply *)), SLOT(ipRequestFinished(QNetworkReply *)));
     m_lastIPCheckTime = QDateTime::currentDateTime();
     QNetworkRequest request;
     request.setUrl(QUrl("http://checkip.dyndns.org"));
@@ -88,7 +91,8 @@ void DNSUpdater::ipRequestFinished(QNetworkReply *reply)
     if (reply->error()) {
         // Error
         qWarning() << Q_FUNC_INFO << "Error:" << reply->errorString();
-  } else {
+    }
+    else {
         // Parse response
         QRegExp ipregex("Current IP Address:\\s+([^<]+)</body>");
         QString ret = reply->readAll();
@@ -103,10 +107,12 @@ void DNSUpdater::ipRequestFinished(QNetworkReply *reply)
                     m_lastIP = new_ip;
                     updateDNSService();
                 }
-      } else {
+            }
+            else {
                 qWarning() << Q_FUNC_INFO << "Failed to construct a QHostAddress from the IP string";
             }
-    } else {
+        }
+        else {
             qWarning() << Q_FUNC_INFO << "Regular expression failed ot capture the IP address";
         }
     }
@@ -120,8 +126,7 @@ void DNSUpdater::updateDNSService()
     qDebug() << Q_FUNC_INFO;
     // Prepare request
     QNetworkAccessManager *manager = new QNetworkAccessManager(this);
-  connect(manager, SIGNAL(finished(QNetworkReply*)),
-          SLOT(ipUpdateFinished(QNetworkReply*)));
+    connect(manager, SIGNAL(finished(QNetworkReply *)), SLOT(ipUpdateFinished(QNetworkReply *)));
     m_lastIPCheckTime = QDateTime::currentDateTime();
     QNetworkRequest request;
     request.setUrl(getUpdateUrl());
@@ -175,7 +180,8 @@ void DNSUpdater::ipUpdateFinished(QNetworkReply *reply)
     if (reply->error()) {
         // Error
         qWarning() << Q_FUNC_INFO << "Error:" << reply->errorString();
-  } else {
+    }
+    else {
         // Pase reply
         processIPUpdateReply(reply->readAll());
     }
@@ -186,7 +192,7 @@ void DNSUpdater::ipUpdateFinished(QNetworkReply *reply)
 
 void DNSUpdater::processIPUpdateReply(const QString &reply)
 {
-  Logger* const logger = Logger::instance();
+    Logger *const logger = Logger::instance();
     qDebug() << Q_FUNC_INFO << reply;
     QString code = reply.split(" ").first();
     qDebug() << Q_FUNC_INFO << "Code:" << code;
@@ -194,7 +200,7 @@ void DNSUpdater::processIPUpdateReply(const QString &reply)
         logger->addMessage(tr("Your dynamic DNS was successfully updated."), Log::INFO);
         return;
     }
-  if (code == "911" || code == "dnserr") {
+    if ((code == "911") || (code == "dnserr")) {
         logger->addMessage(tr("Dynamic DNS error: The service is temporarily unavailable, it will be retried in 30 minutes."), Log::CRITICAL);
         m_lastIP.clear();
         // It will retry in 30 minutes because the timer was not stopped
@@ -235,8 +241,8 @@ void DNSUpdater::processIPUpdateReply(const QString &reply)
 void DNSUpdater::updateCredentials()
 {
     if (m_state == FATAL) return;
-  Preferences* const pref = Preferences::instance();
-  Logger* const logger = Logger::instance();
+    Preferences *const pref = Preferences::instance();
+    Logger *const logger = Logger::instance();
     bool change = false;
     // Get DNS service information
     if (m_service != pref->getDynDNSService()) {
@@ -278,7 +284,7 @@ void DNSUpdater::updateCredentials()
         change = true;
     }
 
-  if (m_state == INVALID_CREDS && change) {
+    if ((m_state == INVALID_CREDS) && change) {
         m_state = OK; // Try again
         m_ipCheckTimer.start();
         checkPublicIP();

src/core/net/dnsupdater.h

@@ -40,32 +40,31 @@
 
 namespace Net
 { 
-
-/*!
- * Based on http://www.dyndns.com/developers/specs/
- */
-class DNSUpdater : public QObject
-{
+    // Based on http://www.dyndns.com/developers/specs/
+    class DNSUpdater : public QObject
+    {
         Q_OBJECT
-public:
+
+    public:
         explicit DNSUpdater(QObject *parent = 0);
         ~DNSUpdater();
+
         static QUrl getRegistrationUrl(int service);
 
-public slots:
+    public slots:
         void updateCredentials();
 
-private slots:
+    private slots:
         void checkPublicIP();
-  void ipRequestFinished(QNetworkReply* reply);
+        void ipRequestFinished(QNetworkReply *reply);
         void updateDNSService();
-  void ipUpdateFinished(QNetworkReply* reply);
+        void ipUpdateFinished(QNetworkReply *reply);
 
-private:
+    private:
         QUrl getUpdateUrl() const;
         void processIPUpdateReply(const QString &reply);
 
-private:
+    private:
         QHostAddress m_lastIP;
         QDateTime m_lastIPCheckTime;
         QTimer m_ipCheckTimer;
@@ -76,11 +75,16 @@ private:
         QString m_username;
         QString m_password;
 
-private:
+    private:
         static const int IP_CHECK_INTERVAL_MS = 1800000; // 30 min
-  enum State { OK, INVALID_CREDS, FATAL };
-};
 
+        enum State
+        {
+            OK,
+            INVALID_CREDS,
+            FATAL
+        };
+    };
 }
 
 #endif // DNSUPDATER_H

src/core/net/smtp.cpp

@@ -50,12 +50,13 @@
 #include <QCryptographicHash>
 #include <QStringList>
 
-namespace {
-const short DEFAULT_PORT = 25;
-const short DEFAULT_PORT_SSL = 465;
-
-QByteArray hmacMD5(QByteArray key, const QByteArray &msg)
+namespace
 {
+    const short DEFAULT_PORT = 25;
+    const short DEFAULT_PORT_SSL = 465;
+
+    QByteArray hmacMD5(QByteArray key, const QByteArray &msg)
+    {
         const int blockSize = 64; // HMAC-MD5 block size
         if (key.length() > blockSize) { // if key is longer than block size (64), reduce key length with MD5 compression
             key = QCryptographicHash::hash(key, QCryptographicHash::Md5);
@@ -77,80 +78,83 @@ QByteArray hmacMD5(QByteArray key, const QByteArray &msg)
         part.append(msg);
         total.append(QCryptographicHash::hash(part, QCryptographicHash::Md5));
         return QCryptographicHash::hash(total, QCryptographicHash::Md5);
-}
+    }
 
-QByteArray determineFQDN()
-{
+    QByteArray determineFQDN()
+    {
         QString hostname = QHostInfo::localHostName();
         if (hostname.isEmpty())
             hostname = "localhost";
 
         return hostname.toLocal8Bit();
-}
+    }
 } // namespace
 
 using namespace Net;
 
-Smtp::Smtp(QObject *parent): QObject(parent),
-  state(Init), use_ssl(false) {
+Smtp::Smtp(QObject *parent)
+    : QObject(parent)
+    , m_state(Init)
+    , m_useSsl(false)
+{
 #ifndef QT_NO_OPENSSL
-  socket = new QSslSocket(this);
+    m_socket = new QSslSocket(this);
 #else
-  socket = new QTcpSocket(this);
+    m_socket = new QTcpSocket(this);
 #endif
 
-  connect(socket, SIGNAL(readyRead()), SLOT(readyRead()));
-  connect(socket, SIGNAL(disconnected()), SLOT(deleteLater()));
+    connect(m_socket, SIGNAL(readyRead()), SLOT(readyRead()));
+    connect(m_socket, SIGNAL(disconnected()), SLOT(deleteLater()));
 
     // Test hmacMD5 function (http://www.faqs.org/rfcs/rfc2202.html)
     Q_ASSERT(hmacMD5("Jefe", "what do ya want for nothing?").toHex()
              == "750c783e6ab0b503eaa86e310a5db738");
-  Q_ASSERT(hmacMD5(QByteArray::fromHex("0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b"),
-                   "Hi There").toHex()
+    Q_ASSERT(hmacMD5(QByteArray::fromHex("0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b"), "Hi There").toHex()
              == "9294727a3638bb1c13f48ef8158bfc9d");
 }
 
-Smtp::~Smtp() {
+Smtp::~Smtp()
+{
     qDebug() << Q_FUNC_INFO;
 }
 
-void Smtp::sendMail(const QString &from, const QString &to, const QString &subject, const QString &body) {
+void Smtp::sendMail(const QString &from, const QString &to, const QString &subject, const QString &body)
+{
     const Preferences* const pref = Preferences::instance();
     QTextCodec* latin1 = QTextCodec::codecForName("latin1");
-  message = "";
-  message += encode_mime_header("Date", QDateTime::currentDateTime().toUTC().toString("ddd, d MMM yyyy hh:mm:ss UT"), latin1);
-  message += encode_mime_header("From", from, latin1);
-  message += encode_mime_header("Subject", subject, latin1);
-  message += encode_mime_header("To", to, latin1);
-  message += "MIME-Version: 1.0\r\n";
-  message += "Content-Type: text/plain; charset=UTF-8\r\n";
-  message += "Content-Transfer-Encoding: base64\r\n";
-  message += "\r\n";
+    m_message = "";
+    m_message += encodeMimeHeader("Date", QDateTime::currentDateTime().toUTC().toString("ddd, d MMM yyyy hh:mm:ss UT"), latin1);
+    m_message += encodeMimeHeader("From", from, latin1);
+    m_message += encodeMimeHeader("Subject", subject, latin1);
+    m_message += encodeMimeHeader("To", to, latin1);
+    m_message += "MIME-Version: 1.0\r\n";
+    m_message += "Content-Type: text/plain; charset=UTF-8\r\n";
+    m_message += "Content-Transfer-Encoding: base64\r\n";
+    m_message += "\r\n";
     // Encode the body in base64
     QString crlf_body = body;
     QByteArray b = crlf_body.replace("\n","\r\n").toUtf8().toBase64();
     int ct = b.length();
     for (int i = 0; i < ct; i += 78)
-  {
-    message += b.mid(i, 78);
-  }
-  this->from = from;
-  rcpt = to;
+        m_message += b.mid(i, 78);
+    m_from = from;
+    m_rcpt = to;
     // Authentication
     if (pref->getMailNotificationSMTPAuth()) {
-    username = pref->getMailNotificationSMTPUsername();
-    password = pref->getMailNotificationSMTPPassword();
+        m_username = pref->getMailNotificationSMTPUsername();
+        m_password = pref->getMailNotificationSMTPPassword();
     }
 
     // Connect to SMTP server
 #ifndef QT_NO_OPENSSL
     if (pref->getMailNotificationSMTPSSL()) {
-    socket->connectToHostEncrypted(pref->getMailNotificationSMTP(), DEFAULT_PORT_SSL);
-    use_ssl = true;
-  } else {
+        m_socket->connectToHostEncrypted(pref->getMailNotificationSMTP(), DEFAULT_PORT_SSL);
+        m_useSsl = true;
+    }
+    else {
 #endif
-    socket->connectToHost(pref->getMailNotificationSMTP(), DEFAULT_PORT);
-    use_ssl = false;
+        m_socket->connectToHost(pref->getMailNotificationSMTP(), DEFAULT_PORT);
+        m_useSsl = false;
 #ifndef QT_NO_OPENSSL
     }
 #endif
@@ -160,18 +164,17 @@ void Smtp::readyRead()
 {
     qDebug() << Q_FUNC_INFO;
     // SMTP is line-oriented
-  buffer += socket->readAll();
-  while (true)
-  {
-    int pos = buffer.indexOf("\r\n");
+    m_buffer += m_socket->readAll();
+    while (true) {
+        int pos = m_buffer.indexOf("\r\n");
         if (pos < 0) return; // Loop exit condition
-    QByteArray line = buffer.left(pos);
-    buffer = buffer.mid(pos + 2);
+        QByteArray line = m_buffer.left(pos);
+        m_buffer = m_buffer.mid(pos + 2);
         qDebug() << "Response line:" << line;
         // Extract reponse code
         QByteArray code = line.left(3);
 
-    switch(state) {
+        switch (m_state) {
         case Init: {
             if (code[0] == '2') {
                 // The server may send a multiline greeting/INIT/220 response.
@@ -180,9 +183,10 @@ void Smtp::readyRead()
                     break;
                 // Connection was successful
                 ehlo();
-      } else {
+            }
+            else {
                 logError("Connection failed, unrecognized reply: "+line);
-        state = Close;
+                m_state = Close;
             }
             break;
         }
@@ -194,82 +198,88 @@ void Smtp::readyRead()
 #ifndef QT_NO_OPENSSL
         case StartTLSSent:
             if (code == "220") {
-        socket->startClientEncryption();
+                m_socket->startClientEncryption();
                 ehlo();
-      } else {
+            }
+            else {
                 authenticate();
             }
             break;
 #endif
         case AuthRequestSent:
         case AuthUsernameSent:
-      if (authType == AuthPlain) authPlain();
-      else if (authType == AuthLogin) authLogin();
+            if (m_authType == AuthPlain) authPlain();
+            else if (m_authType == AuthLogin) authLogin();
             else authCramMD5(line.mid(4));
             break;
         case AuthSent:
         case Authenticated:
             if (code[0] == '2') {
                 qDebug() << "Sending <mail from>...";
-        socket->write("mail from:<" + from.toLatin1() + ">\r\n");
-        socket->flush();
-        state = Rcpt;
-      } else {
+                m_socket->write("mail from:<" + m_from.toLatin1() + ">\r\n");
+                m_socket->flush();
+                m_state = Rcpt;
+            }
+            else {
                 // Authentication failed!
                 logError("Authentication failed, msg: "+line);
-        state = Close;
+                m_state = Close;
             }
             break;
         case Rcpt:
             if (code[0] == '2') {
-        socket->write("rcpt to:<" + rcpt.toLatin1() + ">\r\n");
-        socket->flush();
-        state = Data;
-      } else {
+                m_socket->write("rcpt to:<" + m_rcpt.toLatin1() + ">\r\n");
+                m_socket->flush();
+                m_state = Data;
+            }
+            else {
                 logError("<mail from> was rejected by server, msg: "+line);
-        state = Close;
+                m_state = Close;
             }
             break;
         case Data:
             if (code[0] == '2') {
-        socket->write("data\r\n");
-        socket->flush();
-        state = Body;
-      } else {
+                m_socket->write("data\r\n");
+                m_socket->flush();
+                m_state = Body;
+            }
+            else {
                 logError("<Rcpt to> was rejected by server, msg: "+line);
-        state = Close;
+                m_state = Close;
             }
             break;
         case Body:
             if (code[0] == '3') {
-        socket->write(message + "\r\n.\r\n");
-        socket->flush();
-        state = Quit;
-      } else {
+                m_socket->write(m_message + "\r\n.\r\n");
+                m_socket->flush();
+                m_state = Quit;
+            }
+            else {
                 logError("<data> was rejected by server, msg: "+line);
-        state = Close;
+                m_state = Close;
             }
             break;
         case Quit:
             if (code[0] == '2') {
-        socket->write("QUIT\r\n");
-        socket->flush();
+                m_socket->write("QUIT\r\n");
+                m_socket->flush();
                 // here, we just close.
-        state = Close;
-      } else {
+                m_state = Close;
+            }
+            else {
                 logError("Message was rejected by the server, error: "+line);
-        state = Close;
+                m_state = Close;
             }
             break;
         default:
             qDebug() << "Disconnecting from host";
-      socket->disconnectFromHost();
+            m_socket->disconnectFromHost();
             return;
         }
     }
 }
 
-QByteArray Smtp::encode_mime_header(const QString& key, const QString& value, QTextCodec* latin1, const QByteArray& prefix)
+QByteArray Smtp::encodeMimeHeader(const QString &key, const QString &value, QTextCodec *latin1, const QByteArray &prefix)
 {
     QByteArray rv = "";
     QByteArray line = key.toLatin1() + ": ";
@@ -287,7 +297,8 @@ QByteArray Smtp::encode_mime_header(const QString& key, const QString& value, QT
                 line += " " + word;
             firstWord = false;
         }
-  } else {
+    }
+    else {
         // The text cannot be losslessly encoded as Latin-1. Therefore, we
         // must use base64 encoding.
         QByteArray utf8 = value.toUtf8();
@@ -310,58 +321,65 @@ QByteArray Smtp::encode_mime_header(const QString& key, const QString& value, QT
 void Smtp::ehlo()
 {
     QByteArray address = determineFQDN();
-  socket->write("ehlo " + address + "\r\n");
-  socket->flush();
-  state = EhloSent;
+    m_socket->write("ehlo " + address + "\r\n");
+    m_socket->flush();
+    m_state = EhloSent;
 }
 
 void Smtp::helo()
 {
     QByteArray address = determineFQDN();
-  socket->write("helo " + address + "\r\n");
-  socket->flush();
-  state = HeloSent;
+    m_socket->write("helo " + address + "\r\n");
+    m_socket->flush();
+    m_state = HeloSent;
 }
 
-void Smtp::parseEhloResponse(const QByteArray& code, bool continued, const QString& line)
+void Smtp::parseEhloResponse(const QByteArray &code, bool continued, const QString &line)
 {
     if (code != "250") {
         // Error
-    if (state == EhloSent) {
+        if (m_state == EhloSent) {
             // try to send HELO instead of EHLO
             qDebug() << "EHLO failed, trying HELO instead...";
             helo();
-    } else {
+        }
+        else {
             // Both EHLO and HELO failed, chances are this is NOT
             // a SMTP server
             logError("Both EHLO and HELO failed, msg: "+line);
-      state = Close;
+            m_state = Close;
         }
         return;
     }
-  if (state != EhloGreetReceived) {
+
+    if (m_state != EhloGreetReceived) {
         if (!continued) {
             // greeting only, no extensions
             qDebug() << "No extension";
-      state = EhloDone;
-    } else {
+            m_state = EhloDone;
+        }
+        else {
             // greeting followed by extensions
-      state = EhloGreetReceived;
+            m_state = EhloGreetReceived;
             qDebug () << "EHLO greet received";
             return;
         }
-  } else {
+    }
+    else {
         qDebug() << Q_FUNC_INFO << "Supported extension: " << line.section(' ', 0, 0).toUpper()
                  << line.section(' ', 1);
-    extensions[line.section(' ', 0, 0).toUpper()] = line.section(' ', 1);
+        m_extensions[line.section(' ', 0, 0).toUpper()] = line.section(' ', 1);
         if (!continued)
-      state = EhloDone;
+            m_state = EhloDone;
     }
-  if (state != EhloDone) return;
-  if (extensions.contains("STARTTLS") && use_ssl) {
+
+    if (m_state != EhloDone) return;
+
+    if (m_extensions.contains("STARTTLS") && m_useSsl) {
         qDebug() << "STARTTLS";
         startTLS();
-  } else {
+    }
+    else {
         authenticate();
     }
 }
@@ -369,21 +387,21 @@ void Smtp::parseEhloResponse(const QByteArray& code, bool continued, const QStri
 void Smtp::authenticate()
 {
     qDebug() << Q_FUNC_INFO;
-  if (!extensions.contains("AUTH") ||
-      username.isEmpty() || password.isEmpty()) {
+    if (!m_extensions.contains("AUTH") ||
+        m_username.isEmpty() || m_password.isEmpty()) {
         // Skip authentication
         qDebug() << "Skipping authentication...";
-    state = Authenticated;
+        m_state = Authenticated;
         // At this point the server will not send any response
         // So fill the buffer with a fake one to pass the tests
         // in readyRead()
-    buffer.push_front("250 QBT FAKE RESPONSE\r\n");
+        m_buffer.push_front("250 QBT FAKE RESPONSE\r\n");
         return;
     }
     // AUTH extension is supported, check which
     // authentication modes are supported by
     // the server
-  QStringList auth = extensions["AUTH"].toUpper().split(' ', QString::SkipEmptyParts);
+    QStringList auth = m_extensions["AUTH"].toUpper().split(' ', QString::SkipEmptyParts);
     if (auth.contains("CRAM-MD5")) {
         qDebug() << "Using CRAM-MD5 authentication...";
         authCramMD5();
@@ -395,16 +413,17 @@ void Smtp::authenticate()
     else if (auth.contains("LOGIN")) {
         qDebug() << "Using LOGIN authentication...";
         authLogin();
-  } else {
+    }
+    else {
         // Skip authentication
         logError("The SMTP server does not seem to support any of the authentications modes "
                  "we support [CRAM-MD5|PLAIN|LOGIN], skipping authentication, "
                  "knowing it is likely to fail... Server Auth Modes: "+auth.join("|"));
-    state = Authenticated;
+        m_state = Authenticated;
         // At this point the server will not send any response
         // So fill the buffer with a fake one to pass the tests
         // in readyRead()
-    buffer.push_front("250 QBT FAKE RESPONSE\r\n");
+        m_buffer.push_front("250 QBT FAKE RESPONSE\r\n");
     }
 }
 
@@ -412,9 +431,9 @@ void Smtp::startTLS()
 {
     qDebug() << Q_FUNC_INFO;
 #ifndef QT_NO_OPENSSL
-  socket->write("starttls\r\n");
-  socket->flush();
-  state = StartTLSSent;
+    m_socket->write("starttls\r\n");
+    m_socket->flush();
+    m_state = StartTLSSent;
 #else
     authenticate();
 #endif
@@ -422,56 +441,57 @@ void Smtp::startTLS()
 
 void Smtp::authCramMD5(const QByteArray& challenge)
 {
-  if (state != AuthRequestSent) {
-    socket->write("auth cram-md5\r\n");
-    socket->flush();
-    authType = AuthCramMD5;
-    state = AuthRequestSent;
-  } else {
-    QByteArray response = username.toLatin1() + ' '
-        + hmacMD5(password.toLatin1(), QByteArray::fromBase64(challenge)).toHex();
-    socket->write(response.toBase64() + "\r\n");
-    socket->flush();
-    state = AuthSent;
+    if (m_state != AuthRequestSent) {
+        m_socket->write("auth cram-md5\r\n");
+        m_socket->flush();
+        m_authType = AuthCramMD5;
+        m_state = AuthRequestSent;
+    }
+    else {
+        QByteArray response = m_username.toLatin1() + ' '
+                + hmacMD5(m_password.toLatin1(), QByteArray::fromBase64(challenge)).toHex();
+        m_socket->write(response.toBase64() + "\r\n");
+        m_socket->flush();
+        m_state = AuthSent;
     }
 }
 
 void Smtp::authPlain()
 {
-  if (state != AuthRequestSent) {
-    authType = AuthPlain;
+    if (m_state != AuthRequestSent) {
+        m_authType = AuthPlain;
         // Prepare Auth string
         QByteArray auth;
         auth += '\0';
-    auth += username.toLatin1();
-    qDebug() << "username: " << username.toLatin1();
+        auth += m_username.toLatin1();
+        qDebug() << "username: " << m_username.toLatin1();
         auth += '\0';
-    auth += password.toLatin1();
-    qDebug() << "password: " << password.toLatin1();
+        auth += m_password.toLatin1();
+        qDebug() << "password: " << m_password.toLatin1();
         // Send it
-    socket->write("auth plain "+ auth.toBase64() + "\r\n");
-    socket->flush();
-    state = AuthSent;
+        m_socket->write("auth plain "+ auth.toBase64() + "\r\n");
+        m_socket->flush();
+        m_state = AuthSent;
     }
 }
 
 void Smtp::authLogin()
 {
-  if (state != AuthRequestSent && state != AuthUsernameSent) {
-    socket->write("auth login\r\n");
-    socket->flush();
-    authType = AuthLogin;
-    state = AuthRequestSent;
+    if ((m_state != AuthRequestSent) && (m_state != AuthUsernameSent)) {
+        m_socket->write("auth login\r\n");
+        m_socket->flush();
+        m_authType = AuthLogin;
+        m_state = AuthRequestSent;
     }
-  else if (state == AuthRequestSent) {
-    socket->write(username.toLatin1().toBase64() + "\r\n");
-    socket->flush();
-    state = AuthUsernameSent;
+    else if (m_state == AuthRequestSent) {
+        m_socket->write(m_username.toLatin1().toBase64() + "\r\n");
+        m_socket->flush();
+        m_state = AuthUsernameSent;
     }
     else {
-    socket->write(password.toLatin1().toBase64() + "\r\n");
-    socket->flush();
-    state = AuthSent;
+        m_socket->write(m_password.toLatin1().toBase64() + "\r\n");
+        m_socket->flush();
+        m_state = AuthSent;
     }
 }
 

src/core/net/smtp.h

@@ -52,54 +52,74 @@ QT_END_NAMESPACE
 
 namespace Net
 {
-
-class Smtp : public QObject {
+    class Smtp : public QObject
+    {
         Q_OBJECT
 
-public:
+    public:
         Smtp(QObject *parent = 0);
         ~Smtp();
-  void sendMail(const QString &from, const QString &to, const QString &subject, const QString &body);
 
-private slots:
+        void sendMail(const QString &m_from, const QString &to, const QString &subject, const QString &body);
+
+    private slots:
         void readyRead();
 
-private:
-  QByteArray encode_mime_header(const QString& key, const QString& value, QTextCodec* latin1, const QByteArray& prefix=QByteArray());
+    private:
+        enum States
+        {
+            Rcpt,
+            EhloSent,
+            HeloSent,
+            EhloDone,
+            EhloGreetReceived,
+            AuthRequestSent,
+            AuthSent,
+            AuthUsernameSent,
+            Authenticated,
+            StartTLSSent,
+            Data,
+            Init,
+            Body,
+            Quit,
+            Close
+        };
+
+        enum AuthType
+        {
+            AuthPlain,
+            AuthLogin,
+            AuthCramMD5
+        };
+
+        QByteArray encodeMimeHeader(const QString &key, const QString &value, QTextCodec *latin1, const QByteArray &prefix = QByteArray());
         void ehlo();
         void helo();
-  void parseEhloResponse(const QByteArray& code, bool continued, const QString& line);
+        void parseEhloResponse(const QByteArray &code, bool continued, const QString &line);
         void authenticate();
         void startTLS();
-  void authCramMD5(const QByteArray& challenge = QByteArray());
+        void authCramMD5(const QByteArray &challenge = QByteArray());
         void authPlain();
         void authLogin();
         void logError(const QString &msg);
 
-private:
-  enum states { Rcpt, EhloSent, HeloSent, EhloDone, EhloGreetReceived, AuthRequestSent, AuthSent,
-                AuthUsernameSent, Authenticated, StartTLSSent, Data, Init, Body, Quit, Close };
-  enum AuthType { AuthPlain, AuthLogin, AuthCramMD5 };
-
-private:
-  QByteArray message;
+        QByteArray m_message;
 #ifndef QT_NO_OPENSSL
-  QSslSocket *socket;
+        QSslSocket *m_socket;
 #else
-  QTcpSocket *socket;
+        QTcpSocket *m_socket;
 #endif
-  QString from;
-  QString rcpt;
-  QString response;
-  int state;
-  QHash<QString, QString> extensions;
-  QByteArray buffer;
-  bool use_ssl;
-  AuthType authType;
-  QString username;
-  QString password;
-};
-
+        QString m_from;
+        QString m_rcpt;
+        QString m_response;
+        int m_state;
+        QHash<QString, QString> m_extensions;
+        QByteArray m_buffer;
+        bool m_useSsl;
+        AuthType m_authType;
+        QString m_username;
+        QString m_password;
+    };
 }
 
 #endif