From c1ef846c3d72fe3e2f3deb93da238781b75b6ddd Mon Sep 17 00:00:00 2001 From: nl6720 Date: Sun, 8 Dec 2019 10:32:19 +0200 Subject: [PATCH] Mention lack of HTTPS in WebUI magnet link warning According to Mozilla docs, registerProtocolHandler() is only available when using secure contexts (i.e. HTTPS for everything outside localhost). https://developer.mozilla.org/en-US/docs/Web/API/Navigator/registerProtocolHandler The message "Your browser does not support this feature" does not make this obvious and can lead to confusion if the user is using a modern browser. --- src/webui/www/private/scripts/client.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/webui/www/private/scripts/client.js b/src/webui/www/private/scripts/client.js index 826228738..5aae7b2cb 100644 --- a/src/webui/www/private/scripts/client.js +++ b/src/webui/www/private/scripts/client.js @@ -967,7 +967,10 @@ window.addEvent('load', function() { function registerMagnetHandler() { if (typeof navigator.registerProtocolHandler !== 'function') { - alert("Your browser does not support this feature"); + if (window.location.protocol !== 'https:') + alert(QBT_TR("To use this feature, the WebUI needs to be accessed over HTTPS")QBT_TR[CONTEXT=MainWindow]); + else + alert(QBT_TR("Your browser does not support this feature")QBT_TR[CONTEXT=MainWindow]); return; }