d4708/qBittorrent
1
0
Fork 0
mirror of https://github.com/d47081/qBittorrent.git synced 2025-01-11 15:27:54 +00:00
Code Issues Projects Releases Wiki Activity

Revise Utils::Version comparison operators

Browse Source
This commit is contained in:
Chocobo1 2020-12-11 12:30:13 +08:00
parent 5ba6a5fca1
commit 4d1d5d6b20
No known key found for this signature in database
GPG Key ID: 210D9C873253A68C
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/base/utils/version.h
View File

@ -133,19 +133,15 @@ namespace Utils
return (*this != ThisType {}); return (*this != ThisType {});
} }
constexpr bool operator==(const ThisType &other) const // TODO: remove manually defined operators and use compiler generated `operator<=>()` in C++20
friend bool operator==(const ThisType &left, const ThisType &right)
{ {
return (m_components == other.m_components); return (left.m_components == right.m_components);
} }
constexpr bool operator<(const ThisType &other) const friend bool operator<(const ThisType &left, const ThisType &right)
{ {
return (m_components < other.m_components); return (left.m_components < right.m_components);
}
constexpr bool operator>(const ThisType &other) const
{
return (m_components > other.m_components);
} }
template <typename StringClassWithSplitMethod> template <typename StringClassWithSplitMethod>
@ -198,6 +194,12 @@ namespace Utils
return !(left == right); return !(left == right);
} }
template <typename T, std::size_t N, std::size_t Mandatory>
constexpr bool operator>(const Version<T, N, Mandatory> &left, const Version<T, N, Mandatory> &right)
{
return (right < left);
}
template <typename T, std::size_t N, std::size_t Mandatory> template <typename T, std::size_t N, std::size_t Mandatory>
constexpr bool operator<=(const Version<T, N, Mandatory> &left, const Version<T, N, Mandatory> &right) constexpr bool operator<=(const Version<T, N, Mandatory> &left, const Version<T, N, Mandatory> &right)
{ {