d4708/qBittorrent
1
0
Fork 0
mirror of https://github.com/d47081/qBittorrent.git synced 2025-02-02 01:44:26 +00:00
Code Issues Projects Releases Wiki Activity

Fix memory leaks

Browse Source 
* Fixes a couple of memory leaks (although not dangerous in practice, since we are talking about objects with a lifetime up to the end of the application)
* Fixes heap use after free

PR #19650.
Closes #19632.
This commit is contained in:
Vladimir Golovnev 2023-09-27 08:00:20 +03:00 committed by GitHub
parent cacae42e5e
commit 46c1c9de65
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/base/http/requestparser.cpp
View File

@ -212,7 +212,7 @@ bool RequestParser::parseRequestLine(const QString &line)
if (sepPos >= 0) if (sepPos >= 0)
{ {
const QByteArrayView query = url.mid(sepPos + 1); const QByteArrayView query = QByteArrayView(url).mid(sepPos + 1);
// [rfc3986] 2.4 When to Encode or Decode // [rfc3986] 2.4 When to Encode or Decode
// URL components should be separated before percent-decoding // URL components should be separated before percent-decoding

2
src/base/torrentfileswatcher.cpp
View File

@ -159,7 +159,7 @@ void TorrentFilesWatcher::initWorker()
connect(m_asyncWorker, &TorrentFilesWatcher::Worker::torrentFound, this, &TorrentFilesWatcher::onTorrentFound); connect(m_asyncWorker, &TorrentFilesWatcher::Worker::torrentFound, this, &TorrentFilesWatcher::onTorrentFound);
m_asyncWorker->moveToThread(m_ioThread.get()); m_asyncWorker->moveToThread(m_ioThread.get());
connect(m_ioThread.get(), &QThread::finished, this, [this] { delete m_asyncWorker; }); connect(m_ioThread.get(), &QObject::destroyed, this, [this] { delete m_asyncWorker; });
m_ioThread->start(); m_ioThread->start();
for (auto it = m_watchedFolders.cbegin(); it != m_watchedFolders.cend(); ++it) for (auto it = m_watchedFolders.cbegin(); it != m_watchedFolders.cend(); ++it)

2
src/gui/lineedit.cpp
View File

@ -38,7 +38,7 @@
LineEdit::LineEdit(QWidget *parent) LineEdit::LineEdit(QWidget *parent)
: QLineEdit(parent) : QLineEdit(parent)
{ {
auto *action = new QAction(UIThemeManager::instance()->getIcon(u"edit-find"_s), QString()); auto *action = new QAction(UIThemeManager::instance()->getIcon(u"edit-find"_s), QString(), this);
addAction(action, QLineEdit::LeadingPosition); addAction(action, QLineEdit::LeadingPosition);
setClearButtonEnabled(true); setClearButtonEnabled(true);