From 44e4dd3700122985ac71db97d2256472bfe61b46 Mon Sep 17 00:00:00 2001
From: Chocobo1 <Chocobo1@users.noreply.github.com>
Date: Wed, 20 Jan 2021 12:12:07 +0800
Subject: [PATCH] Don't let "program update" dialog steal focus

And also avoid creating an unnecessary event loop.
Closes #14250.
---
 src/gui/mainwindow.cpp | 64 ++++++++++++++++++++++++++++--------------
 src/gui/mainwindow.h   |  2 +-
 2 files changed, 44 insertions(+), 22 deletions(-)

diff --git a/src/gui/mainwindow.cpp b/src/gui/mainwindow.cpp
index 291f7260b..5983ab8a6 100644
--- a/src/gui/mainwindow.cpp
+++ b/src/gui/mainwindow.cpp
@@ -1897,35 +1897,57 @@ void MainWindow::on_actionDownloadFromURL_triggered()
 }
 
 #if defined(Q_OS_WIN) || defined(Q_OS_MACOS)
-void MainWindow::handleUpdateCheckFinished(bool updateAvailable, QString newVersion, bool invokedByUser)
+void MainWindow::handleUpdateCheckFinished(const bool updateAvailable, const QString &newVersion, const bool invokedByUser)
 {
-    QMessageBox::StandardButton answer = QMessageBox::Yes;
+    m_ui->actionCheckForUpdates->setEnabled(true);
+    m_ui->actionCheckForUpdates->setText(tr("&Check for Updates"));
+    m_ui->actionCheckForUpdates->setToolTip(tr("Check for program updates"));
+
+    QObject *signalSender = sender();
+
     if (updateAvailable)
     {
-        answer = QMessageBox::question(this, tr("qBittorrent Update Available")
-            , tr("A new version is available.") + "<br/>"
-                + tr("Do you want to download %1?").arg(newVersion) + "<br/><br/>"
-                + QString::fromLatin1("<a href=\"https://www.qbittorrent.org/news.php\">%1</a>").arg(tr("Open changelog..."))
-            , QMessageBox::Yes | QMessageBox::No, QMessageBox::Yes);
-        if (answer == QMessageBox::Yes)
+        const QString msg {tr("A new version is available.") + "<br/>"
+            + tr("Do you want to download %1?").arg(newVersion) + "<br/><br/>"
+            + QString::fromLatin1("<a href=\"https://www.qbittorrent.org/news.php\">%1</a>").arg(tr("Open changelog..."))};
+        auto *msgBox = new QMessageBox {QMessageBox::Question, tr("qBittorrent Update Available"), msg
+            , (QMessageBox::Yes | QMessageBox::No), this};
+        msgBox->setAttribute(Qt::WA_DeleteOnClose);
+        msgBox->setAttribute(Qt::WA_ShowWithoutActivating);
+        msgBox->setDefaultButton(QMessageBox::Yes);
+        connect(msgBox, &QMessageBox::buttonClicked, this, [this, msgBox, signalSender](QAbstractButton *button)
         {
-            // The user want to update, let's download the update
-            ProgramUpdater *updater = dynamic_cast<ProgramUpdater * >(sender());
-            updater->updateProgram();
-        }
+            if (msgBox->buttonRole(button) == QMessageBox::YesRole)
+            {
+                // The user want to update, let's download the update
+                auto *updater = dynamic_cast<ProgramUpdater *>(signalSender);
+                updater->updateProgram();
+            }
+            else
+            {
+                if (Preferences::instance()->isUpdateCheckEnabled())
+                    m_programUpdateTimer->start();
+            }
+
+            signalSender->deleteLater();
+        });
+        msgBox->open();
     }
     else if (invokedByUser)
     {
-        QMessageBox::information(this, QLatin1String("qBittorrent"),
-                                 tr("No updates available.\nYou are already using the latest version."));
+        auto *msgBox = new QMessageBox {QMessageBox::Information, QLatin1String("qBittorrent")
+            , tr("No updates available.\nYou are already using the latest version.")
+            , QMessageBox::Ok, this};
+        msgBox->setAttribute(Qt::WA_DeleteOnClose);
+        connect(msgBox, &QDialog::finished, this, [this, signalSender](const int)
+        {
+            if (Preferences::instance()->isUpdateCheckEnabled())
+                m_programUpdateTimer->start();
+
+            signalSender->deleteLater();
+        });
+        msgBox->open();
     }
-    sender()->deleteLater();
-    m_ui->actionCheckForUpdates->setEnabled(true);
-    m_ui->actionCheckForUpdates->setText(tr("&Check for Updates"));
-    m_ui->actionCheckForUpdates->setToolTip(tr("Check for program updates"));
-    // Don't bother the user again in this session if he chose to ignore the update
-    if (Preferences::instance()->isUpdateCheckEnabled() && (answer == QMessageBox::Yes))
-        m_programUpdateTimer->start();
 }
 #endif
 
diff --git a/src/gui/mainwindow.h b/src/gui/mainwindow.h
index cea1140fb..6f0ee5998 100644
--- a/src/gui/mainwindow.h
+++ b/src/gui/mainwindow.h
@@ -135,7 +135,7 @@ private slots:
     void askRecursiveTorrentDownloadConfirmation(BitTorrent::Torrent *const torrent);
     void optionsSaved();
 #if defined(Q_OS_WIN) || defined(Q_OS_MACOS)
-    void handleUpdateCheckFinished(bool updateAvailable, QString newVersion, bool invokedByUser);
+    void handleUpdateCheckFinished(bool updateAvailable, const QString &newVersion, bool invokedByUser);
 #endif
     void toggleAlternativeSpeeds();