d4708/qBittorrent
1
0
Fork 0
mirror of https://github.com/d47081/qBittorrent.git synced 2025-01-11 07:18:08 +00:00
Code Issues Projects Releases Wiki Activity

Avoid performance penalty from type erasure

Browse Source 
On average the affected code path is 0.1% faster and the result binary
is 10 KB smaller.
This commit is contained in:
Chocobo1 2019-04-26 01:48:40 +08:00
parent 6435e994f1
commit 44e4a5b13a
No known key found for this signature in database
GPG Key ID: 210D9C873253A68C
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/base/settingvalue.h
View File

@ -29,7 +29,6 @@
#ifndef SETTINGVALUE_H
#define SETTINGVALUE_H
#include <functional>
#include <type_traits>
#include <QMetaEnum>
@ -41,8 +40,6 @@
template <typename T>
class CachedSettingValue
{
using ProxyFunc = std::function<T (const T&)>;
public:
explicit CachedSettingValue(const char *keyName, const T &defaultValue = T())
: m_keyName(QLatin1String(keyName))
@ -50,8 +47,11 @@ public:
{
}
// The signature of the ProxyFunc should be equivalent to the following:
// T proxyFunc(const T &a);
template <typename ProxyFunc>
explicit CachedSettingValue(const char *keyName, const T &defaultValue
, const ProxyFunc &proxyFunc)
, ProxyFunc proxyFunc)
: m_keyName(QLatin1String(keyName))
, m_value(proxyFunc(loadValue(defaultValue)))
{