d4708/qBittorrent
1
0
Fork 0
mirror of https://github.com/d47081/qBittorrent.git synced 2025-02-02 09:55:55 +00:00
Code Issues Projects Releases Wiki Activity

- Fixed an overflow that could cause ETA to become negative sometimes (hitted an assert)

Browse Source
This commit is contained in:
Christophe Dumez 2007-09-16 12:30:41 +00:00
parent 925ecb3464
commit 3cb34ed7ee
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
TODO
View File

@ -53,7 +53,6 @@
* beta 7 * beta 7
- update doc for plugins (and add screenies) - update doc for plugins (and add screenies)
- update doc for options - update doc for options
- See bug about negative ETA
- Translations update (IN PROGRESS) - Translations update (IN PROGRESS)
- Wait that http://pastebin.ca/690649 is fixed - Wait that http://pastebin.ca/690649 is fixed
@ -114,6 +113,7 @@ beta6->beta7 changelog:
- BUGFIX: improved search engine plugin manager code and fixed bugs - BUGFIX: improved search engine plugin manager code and fixed bugs
- BUGFIX: Dropped Qt4.2 support, becomes too difficult to maintain - BUGFIX: Dropped Qt4.2 support, becomes too difficult to maintain
- BUGFIX: Fixed deprecation warning with latest libtorrent svn - BUGFIX: Fixed deprecation warning with latest libtorrent svn
- BUGFIX: Fixed an overflow causing ETA to become negative sometimes (hitted an assert)
- COSMETIC: Improved some icons - COSMETIC: Improved some icons
- COSMETIC: Totally redesigned program preferences - COSMETIC: Totally redesigned program preferences
- COSMETIC: Improved systray tooltip style - COSMETIC: Improved systray tooltip style

11
src/bittorrent.cpp
View File

@ -160,13 +160,14 @@ void bittorrent::updateETAs() {
unsigned int nbETAs = listEtas.size(); unsigned int nbETAs = listEtas.size();
Q_ASSERT(nbETAs); Q_ASSERT(nbETAs);
foreach(val, listEtas) { foreach(val, listEtas) {
// TODO: Remove this debug when #137223 is fixed
qDebug("old moy: %ld", (long)moy);
moy += (qlonglong)((double)val/(double)nbETAs); moy += (qlonglong)((double)val/(double)nbETAs);
qDebug("ETA: %ld, nbETAs: %d, moy: %ld", (long)val, nbETAs, (long)moy); if(moy < 0) break;
Q_ASSERT(moy >= 0); }
if(moy < 0) {
ETAs.remove(hash);
} else {
ETAs[hash] = moy;
} }
ETAs[hash] = moy;
} }
} }
} }