d4708/qBittorrent
1
0
Fork 0
mirror of https://github.com/d47081/qBittorrent.git synced 2025-01-30 16:34:16 +00:00
Code Issues Projects Releases Wiki Activity

Avoid unnecessary memory writes

Browse Source 
Before this change, qbt spent ~1% in these two functions, now it
only spends about ~0.5% in my naive testing.
This commit is contained in:
Chocobo1 2020-03-04 02:53:31 +08:00
parent b519ece18b
commit 24cd7c3611
No known key found for this signature in database
GPG Key ID: 210D9C873253A68C
2 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/base/bittorrent/peerinfo.cpp
View File

@ -208,11 +208,10 @@ qlonglong PeerInfo::totalDownload() const
QBitArray PeerInfo::pieces() const QBitArray PeerInfo::pieces() const
{ {
QBitArray result(m_nativeInfo.pieces.size()); QBitArray result(m_nativeInfo.pieces.size());
for (int i = 0; i < result.size(); ++i) {
int i = 0; if (m_nativeInfo.pieces[i])
for (const bool bit : m_nativeInfo.pieces) result.setBit(i, true);
result.setBit(i++, bit); }
return result; return result;
} }

8
src/base/bittorrent/torrenthandle.cpp
View File

@ -1202,10 +1202,10 @@ QVector<PeerInfo> TorrentHandle::peers() const
QBitArray TorrentHandle::pieces() const QBitArray TorrentHandle::pieces() const
{ {
QBitArray result(m_nativeStatus.pieces.size()); QBitArray result(m_nativeStatus.pieces.size());
for (int i = 0; i < result.size(); ++i) {
for (int i = 0; i < m_nativeStatus.pieces.size(); ++i) if (m_nativeStatus.pieces[LTPieceIndex {i}])
result.setBit(i, m_nativeStatus.pieces.get_bit(LTPieceIndex {i})); result.setBit(i, true);
}
return result; return result;
} }