d4708/qBittorrent
1
0
Fork 0
mirror of https://github.com/d47081/qBittorrent.git synced 2025-02-05 19:34:17 +00:00
Code Issues Projects Releases Wiki Activity

Clean up code

Browse Source
This commit is contained in:
Chocobo1 2022-07-24 18:07:52 +08:00
parent e33f73d08e
commit 243d130667
No known key found for this signature in database
GPG Key ID: 210D9C873253A68C
1 changed files with 13 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
src/gui/fspathedit.cpp
View File

@ -70,6 +70,7 @@ class FileSystemPathEdit::FileSystemPathEditPrivate
Q_DECLARE_PUBLIC(FileSystemPathEdit) Q_DECLARE_PUBLIC(FileSystemPathEdit)
Q_DISABLE_COPY_MOVE(FileSystemPathEditPrivate) Q_DISABLE_COPY_MOVE(FileSystemPathEditPrivate)
private:
FileSystemPathEditPrivate(FileSystemPathEdit *q, Private::IFileEditorWithCompletion *editor); FileSystemPathEditPrivate(FileSystemPathEdit *q, Private::IFileEditorWithCompletion *editor);
void modeChanged(); void modeChanged();
@ -81,7 +82,7 @@ class FileSystemPathEdit::FileSystemPathEditPrivate
QAction *m_browseAction = nullptr; QAction *m_browseAction = nullptr;
QToolButton *m_browseBtn = nullptr; QToolButton *m_browseBtn = nullptr;
QString m_fileNameFilter; QString m_fileNameFilter;
Mode m_mode; Mode m_mode = FileSystemPathEdit::Mode::FileOpen;
Path m_lastSignaledPath; Path m_lastSignaledPath;
QString m_dialogCaption; QString m_dialogCaption;
Private::FileSystemPathValidator *m_validator = nullptr; Private::FileSystemPathValidator *m_validator = nullptr;
@ -91,20 +92,22 @@ FileSystemPathEdit::FileSystemPathEditPrivate::FileSystemPathEditPrivate(
FileSystemPathEdit *q, Private::IFileEditorWithCompletion *editor) FileSystemPathEdit *q, Private::IFileEditorWithCompletion *editor)
: q_ptr {q} : q_ptr {q}
, m_editor {editor} , m_editor {editor}
, m_browseAction {new QAction(q)} , m_browseAction {new QAction(QApplication::style()->standardIcon(QStyle::SP_DirOpenIcon), browseButtonFullText.tr(), q)}
, m_browseBtn {new QToolButton(q)} , m_browseBtn {new QToolButton(q)}
, m_mode {FileSystemPathEdit::Mode::FileOpen} , m_fileNameFilter {tr("Any file") + u" (*)"}
, m_validator {new Private::FileSystemPathValidator(q)} , m_validator {new Private::FileSystemPathValidator(q)}
{ {
m_browseAction->setIconText(browseButtonBriefText.tr()); m_browseAction->setIconText(browseButtonBriefText.tr());
m_browseAction->setText(browseButtonFullText.tr());
m_browseAction->setToolTip(browseButtonFullText.tr().remove(u'&'));
m_browseAction->setShortcut(Qt::CTRL + Qt::Key_B); m_browseAction->setShortcut(Qt::CTRL + Qt::Key_B);
m_browseAction->setToolTip(browseButtonFullText.tr().remove(u'&'));
m_browseBtn->setDefaultAction(m_browseAction); m_browseBtn->setDefaultAction(m_browseAction);
m_fileNameFilter = tr("Any file") + u" (*)";
m_editor->setBrowseAction(m_browseAction);
m_validator->setStrictMode(false); m_validator->setStrictMode(false);
m_editor->setBrowseAction(m_browseAction);
m_editor->setValidator(m_validator); m_editor->setValidator(m_validator);
modeChanged(); modeChanged();
} }
@ -160,22 +163,7 @@ QString FileSystemPathEdit::FileSystemPathEditPrivate::dialogCaptionOrDefault()
void FileSystemPathEdit::FileSystemPathEditPrivate::modeChanged() void FileSystemPathEdit::FileSystemPathEditPrivate::modeChanged()
{ {
bool showDirsOnly = false; m_editor->completeDirectoriesOnly((m_mode == FileSystemPathEdit::Mode::DirectoryOpen) || (m_mode == FileSystemPathEdit::Mode::DirectorySave));
switch (m_mode)
{
case FileSystemPathEdit::Mode::FileOpen:
case FileSystemPathEdit::Mode::FileSave:
showDirsOnly = false;
break;
case FileSystemPathEdit::Mode::DirectoryOpen:
case FileSystemPathEdit::Mode::DirectorySave:
showDirsOnly = true;
break;
default:
throw std::logic_error("Unknown FileSystemPathEdit mode");
}
m_browseAction->setIcon(QApplication::style()->standardIcon(QStyle::SP_DirOpenIcon));
m_editor->completeDirectoriesOnly(showDirsOnly);
m_validator->setExistingOnly(m_mode != FileSystemPathEdit::Mode::FileSave); m_validator->setExistingOnly(m_mode != FileSystemPathEdit::Mode::FileSave);
m_validator->setDirectoriesOnly((m_mode == FileSystemPathEdit::Mode::DirectoryOpen) || (m_mode == FileSystemPathEdit::Mode::DirectorySave)); m_validator->setDirectoriesOnly((m_mode == FileSystemPathEdit::Mode::DirectoryOpen) || (m_mode == FileSystemPathEdit::Mode::DirectorySave));
@ -297,10 +285,10 @@ FileSystemPathEdit::Mode FileSystemPathEdit::mode() const
return d->m_mode; return d->m_mode;
} }
void FileSystemPathEdit::setMode(FileSystemPathEdit::Mode theMode) void FileSystemPathEdit::setMode(const Mode mode)
{ {
Q_D(FileSystemPathEdit); Q_D(FileSystemPathEdit);
d->m_mode = theMode; d->m_mode = mode;
d->modeChanged(); d->modeChanged();
} }