From 44e4b5d23814ecd9d6fc40288259e11c26c1467e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lu=C3=ADs=20Pereira?= Date: Mon, 12 Feb 2018 16:36:03 +0000 Subject: [PATCH] Don't use qDeleteAll() on temporaries qDeleteAll() is being used on an unnecessary temporary container created by QHash::values(). Using qDeleteAll(mycontainer) instead. --- src/base/searchengine.cpp | 2 +- src/gui/properties/trackerlist.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/base/searchengine.cpp b/src/base/searchengine.cpp index 1eba4fab1..23ef24363 100644 --- a/src/base/searchengine.cpp +++ b/src/base/searchengine.cpp @@ -84,7 +84,7 @@ SearchEngine::SearchEngine() SearchEngine::~SearchEngine() { - qDeleteAll(m_plugins.values()); + qDeleteAll(m_plugins); cancelSearch(); } diff --git a/src/gui/properties/trackerlist.cpp b/src/gui/properties/trackerlist.cpp index 1c4e10e9c..cfb88379c 100644 --- a/src/gui/properties/trackerlist.cpp +++ b/src/gui/properties/trackerlist.cpp @@ -234,7 +234,7 @@ void TrackerList::moveSelectionDown() void TrackerList::clear() { - qDeleteAll(m_trackerItems.values()); + qDeleteAll(m_trackerItems); m_trackerItems.clear(); m_DHTItem->setText(COL_STATUS, ""); m_DHTItem->setText(COL_SEEDS, "");