From 1a099fa7427f2b5775d5c86c34f7402b7358bb55 Mon Sep 17 00:00:00 2001
From: sledgehammer999 <hammered999@gmail.com>
Date: Sun, 30 Apr 2017 23:27:28 +0300
Subject: [PATCH] Don't enforce an explicit value for TriState cmd options.
 Most code from Brian Kendall <guygizmo@gmail.com> (@briankendall)

---
 src/app/options.cpp | 60 ++++++++++++++++++++++++++++-----------------
 1 file changed, 38 insertions(+), 22 deletions(-)

diff --git a/src/app/options.cpp b/src/app/options.cpp
index ecf825286..c8addae45 100644
--- a/src/app/options.cpp
+++ b/src/app/options.cpp
@@ -242,45 +242,59 @@ namespace
 
     // Option that is explicitly set to true or false, and whose value is undefined when unspecified.
     // May not have a shortcut.
-    class TriStateBoolOption: protected StringOption
+    class TriStateBoolOption: protected Option
     {
     public:
-        constexpr TriStateBoolOption(const char *name)
-            : StringOption {name}
+        constexpr TriStateBoolOption(const char *name, bool defaultValue)
+            : Option {name, 0}
+            , m_defaultValue(defaultValue)
         {
         }
 
-        using StringOption::operator==;
-        
+        bool operator==(const QString &arg) const
+        {
+            QStringList parts = arg.split(QLatin1Char('='));
+            return parts[0] == fullParameter();
+        }
+
         QString usage() const
         {
-            return StringOption::usage(QLatin1String("true|false"));
+            return padUsageText(fullParameter() + QLatin1String("=<true|false>"));
         }
 
         TriStateBool value(const QString &arg) const
         {
-            QString val = StringOption::value(arg);
-            
-            if (val.toUpper() == QLatin1String("TRUE") || val == QLatin1String("1")) {
-                return TriStateBool::True;
-            }
-            else if (val.toUpper() == QLatin1String("FALSE") || val == QLatin1String("0")) {
-                return TriStateBool::False;
+            QStringList parts = arg.split(QLatin1Char('='));
+
+            if (parts.size() == 1) {
+                return TriStateBool(m_defaultValue);
             }
-            else {
-                throw CommandLineParameterError(QObject::tr("Parameter '%1' must follow syntax '%1=%2'",
-                                                            "e.g. Parameter '--add-paused' must follow syntax "
-                                                            "'--add-paused=<true|false>'")
-                                                .arg(fullParameter())
-                                                .arg(QLatin1String("<true|false>")));
+            else if (parts.size() == 2) {
+                QString val = parts[1];
+
+                if (val.toUpper() == QLatin1String("TRUE") || val == QLatin1String("1")) {
+                    return TriStateBool::True;
+                }
+                else if (val.toUpper() == QLatin1String("FALSE") || val == QLatin1String("0")) {
+                    return TriStateBool::False;
+                }
             }
+
+            throw CommandLineParameterError(QObject::tr("Parameter '%1' must follow syntax '%1=%2'",
+                                                        "e.g. Parameter '--add-paused' must follow syntax "
+                                                        "'--add-paused=<true|false>'")
+                                            .arg(fullParameter())
+                                            .arg(QLatin1String("<true|false>")));
         }
 
         TriStateBool value(const QProcessEnvironment &env) const
         {
-            QString val = env.value(envVarName());
+            QString val = env.value(envVarName(), "-1");
             
             if (val.isEmpty()) {
+                return TriStateBool(m_defaultValue);
+            }
+            else if (val == QLatin1String("-1")) {
                 return TriStateBool::Undefined;
             }
             else if (val.toUpper() == QLatin1String("TRUE") || val == QLatin1String("1")) {
@@ -295,6 +309,8 @@ namespace
                 return TriStateBool::Undefined;
             }
         }
+
+        bool m_defaultValue;
     };
 
     bool operator==(const QString &s, const TriStateBoolOption &o)
@@ -315,12 +331,12 @@ namespace
     constexpr const BoolOption PORTABLE_OPTION = {"portable"};
     constexpr const BoolOption RELATIVE_FASTRESUME = {"relative-fastresume"};
     constexpr const StringOption SAVE_PATH_OPTION = {"save-path"};
-    constexpr const TriStateBoolOption PAUSED_OPTION = {"add-paused"};
+    constexpr const TriStateBoolOption PAUSED_OPTION = {"add-paused", true};
     constexpr const BoolOption SKIP_HASH_CHECK_OPTION = {"skip-hash-check"};
     constexpr const StringOption CATEGORY_OPTION = {"category"};
     constexpr const BoolOption SEQUENTIAL_OPTION = {"sequential"};
     constexpr const BoolOption FIRST_AND_LAST_OPTION = {"first-and-last"};
-    constexpr const TriStateBoolOption SKIP_DIALOG_OPTION = {"skip-dialog"};
+    constexpr const TriStateBoolOption SKIP_DIALOG_OPTION = {"skip-dialog", true};
 }
 
 QBtCommandLineParameters::QBtCommandLineParameters(const QProcessEnvironment &env)