Browse Source

Merge pull request #5127 from Chocobo1/shutdown

Fix Shutdown confirmation
adaptive-webui-19844
sledgehammer999 9 years ago
parent
commit
18148a3aed
  1. 50
      src/app/application.cpp
  2. 2
      src/app/application.h
  3. 2
      src/base/utils/misc.cpp
  4. 3
      src/base/utils/misc.h

50
src/app/application.cpp

@ -96,9 +96,7 @@ namespace
Application::Application(const QString &id, int &argc, char **argv) Application::Application(const QString &id, int &argc, char **argv)
: BaseApplication(id, argc, argv) : BaseApplication(id, argc, argv)
, m_running(false) , m_running(false)
#ifndef DISABLE_GUI
, m_shutdownAct(ShutdownDialogAction::Exit) , m_shutdownAct(ShutdownDialogAction::Exit)
#endif
{ {
Logger::initInstance(); Logger::initInstance();
SettingsStorage::initInstance(); SettingsStorage::initInstance();
@ -283,40 +281,35 @@ void Application::torrentFinished(BitTorrent::TorrentHandle *const torrent)
void Application::allTorrentsFinished() void Application::allTorrentsFinished()
{ {
#ifndef DISABLE_GUI
Preferences *const pref = Preferences::instance(); Preferences *const pref = Preferences::instance();
bool isExit = pref->shutdownqBTWhenDownloadsComplete();
bool isShutdown = pref->shutdownWhenDownloadsComplete();
bool isSuspend = pref->suspendWhenDownloadsComplete();
bool isHibernate = pref->hibernateWhenDownloadsComplete();
bool will_shutdown = (pref->shutdownWhenDownloadsComplete() bool haveAction = isExit || isShutdown || isSuspend || isHibernate;
|| pref->shutdownqBTWhenDownloadsComplete() if (!haveAction) return;
|| pref->suspendWhenDownloadsComplete()
|| pref->hibernateWhenDownloadsComplete());
// Auto-Shutdown
if (will_shutdown) {
bool suspend = pref->suspendWhenDownloadsComplete();
bool hibernate = pref->hibernateWhenDownloadsComplete();
bool shutdown = pref->shutdownWhenDownloadsComplete();
// Confirm shutdown
ShutdownDialogAction action = ShutdownDialogAction::Exit; ShutdownDialogAction action = ShutdownDialogAction::Exit;
if (suspend) if (isSuspend)
action = ShutdownDialogAction::Suspend; action = ShutdownDialogAction::Suspend;
else if (hibernate) else if (isHibernate)
action = ShutdownDialogAction::Hibernate; action = ShutdownDialogAction::Hibernate;
else if (shutdown) else if (isShutdown)
action = ShutdownDialogAction::Shutdown; action = ShutdownDialogAction::Shutdown;
if ((action == ShutdownDialogAction::Exit) && (!pref->dontConfirmAutoExit())) { #ifndef DISABLE_GUI
if (!ShutdownConfirmDlg::askForConfirmation(action)) // ask confirm
return; if ((action == ShutdownDialogAction::Exit) && (pref->dontConfirmAutoExit())) {
// do nothing & skip confirm
} }
else { //exit and shutdown else {
if (!ShutdownConfirmDlg::askForConfirmation(action)) if (!ShutdownConfirmDlg::askForConfirmation(action)) return;
return;
} }
#endif // DISABLE_GUI
// Actually shut down // Actually shut down
if (suspend || hibernate || shutdown) { if (action != ShutdownDialogAction::Exit) {
qDebug("Preparing for auto-shutdown because all downloads are complete!"); qDebug("Preparing for auto-shutdown because all downloads are complete!");
// Disabling it for next time // Disabling it for next time
pref->setShutdownWhenDownloadsComplete(false); pref->setShutdownWhenDownloadsComplete(false);
@ -325,10 +318,9 @@ void Application::allTorrentsFinished()
// Make sure preferences are synced before exiting // Make sure preferences are synced before exiting
m_shutdownAct = action; m_shutdownAct = action;
} }
qDebug("Exiting the application"); qDebug("Exiting the application");
exit(); exit();
}
#endif // DISABLE_GUI
} }
bool Application::sendParams(const QStringList &params) bool Application::sendParams(const QStringList &params)
@ -371,7 +363,7 @@ int Application::exec(const QStringList &params)
BitTorrent::Session::initInstance(); BitTorrent::Session::initInstance();
connect(BitTorrent::Session::instance(), SIGNAL(torrentFinished(BitTorrent::TorrentHandle *const)), SLOT(torrentFinished(BitTorrent::TorrentHandle *const))); connect(BitTorrent::Session::instance(), SIGNAL(torrentFinished(BitTorrent::TorrentHandle *const)), SLOT(torrentFinished(BitTorrent::TorrentHandle *const)));
connect(BitTorrent::Session::instance(), SIGNAL(allTorrentsFinished()), SLOT(allTorrentsFinished())); connect(BitTorrent::Session::instance(), SIGNAL(allTorrentsFinished()), SLOT(allTorrentsFinished()), Qt::QueuedConnection);
#ifndef DISABLE_COUNTRIES_RESOLUTION #ifndef DISABLE_COUNTRIES_RESOLUTION
Net::GeoIPManager::initInstance(); Net::GeoIPManager::initInstance();
@ -595,6 +587,7 @@ void Application::cleanup()
delete m_fileLogger; delete m_fileLogger;
Logger::freeInstance(); Logger::freeInstance();
IconProvider::freeInstance(); IconProvider::freeInstance();
#ifndef DISABLE_GUI #ifndef DISABLE_GUI
#ifdef Q_OS_WIN #ifdef Q_OS_WIN
typedef BOOL (WINAPI *PSHUTDOWNBRDESTROY)(HWND); typedef BOOL (WINAPI *PSHUTDOWNBRDESTROY)(HWND);
@ -604,9 +597,10 @@ void Application::cleanup()
shutdownBRDestroy((HWND)m_window->effectiveWinId()); shutdownBRDestroy((HWND)m_window->effectiveWinId());
#endif // Q_OS_WIN #endif // Q_OS_WIN
delete m_window; delete m_window;
#endif // DISABLE_GUI
if (m_shutdownAct != ShutdownDialogAction::Exit) { if (m_shutdownAct != ShutdownDialogAction::Exit) {
qDebug() << "Sending computer shutdown/suspend/hibernate signal..."; qDebug() << "Sending computer shutdown/suspend/hibernate signal...";
Utils::Misc::shutdownComputer(m_shutdownAct); Utils::Misc::shutdownComputer(m_shutdownAct);
} }
#endif
} }

2
src/app/application.h

@ -111,10 +111,10 @@ private slots:
private: private:
bool m_running; bool m_running;
ShutdownDialogAction m_shutdownAct;
#ifndef DISABLE_GUI #ifndef DISABLE_GUI
QPointer<MainWindow> m_window; QPointer<MainWindow> m_window;
ShutdownDialogAction m_shutdownAct;
#endif #endif
#ifndef DISABLE_WEBUI #ifndef DISABLE_WEBUI

2
src/base/utils/misc.cpp

@ -91,7 +91,6 @@ static struct { const char *source; const char *comment; } units[] = {
QT_TRANSLATE_NOOP3("misc", "EiB", "exbibytes (1024 pebibytes)") QT_TRANSLATE_NOOP3("misc", "EiB", "exbibytes (1024 pebibytes)")
}; };
#ifndef DISABLE_GUI
void Utils::Misc::shutdownComputer(const ShutdownDialogAction &action) void Utils::Misc::shutdownComputer(const ShutdownDialogAction &action)
{ {
#if (defined(Q_OS_UNIX) && !defined(Q_OS_MAC)) && defined(QT_DBUS_LIB) #if (defined(Q_OS_UNIX) && !defined(Q_OS_MAC)) && defined(QT_DBUS_LIB)
@ -216,7 +215,6 @@ void Utils::Misc::shutdownComputer(const ShutdownDialogAction &action)
(PTOKEN_PRIVILEGES) NULL, 0); (PTOKEN_PRIVILEGES) NULL, 0);
#endif #endif
} }
#endif // DISABLE_GUI
#ifndef DISABLE_GUI #ifndef DISABLE_GUI
// Get screen center // Get screen center

3
src/base/utils/misc.h

@ -67,8 +67,9 @@ namespace Utils
QString parseHtmlLinks(const QString &raw_text); QString parseHtmlLinks(const QString &raw_text);
bool isUrl(const QString &s); bool isUrl(const QString &s);
#ifndef DISABLE_GUI
void shutdownComputer(const ShutdownDialogAction &action); void shutdownComputer(const ShutdownDialogAction &action);
#ifndef DISABLE_GUI
// Get screen center // Get screen center
QPoint screenCenter(QWidget *win); QPoint screenCenter(QWidget *win);
QSize smallIconSize(); QSize smallIconSize();

Loading…
Cancel
Save