Merge pull request #1250 from botanegg/cppcheck

Corrections from running cppcheck v2.

src/preferences/preferences.h

@@ -894,7 +894,7 @@ public:
     return value("Preferences/DynDNS/DomainName", "changeme.dyndns.org").toString();
   }
 
-  void setDynDomainName(const QString name) {
+  void setDynDomainName(const QString &name) {
     setValue("Preferences/DynDNS/DomainName", name);
   }
 
@@ -902,7 +902,7 @@ public:
     return value("Preferences/DynDNS/Username").toString();
   }
 
-  void setDynDNSUsername(const QString username) {
+  void setDynDNSUsername(const QString &username) {
     setValue("Preferences/DynDNS/Username", username);
   }
 
@@ -910,7 +910,7 @@ public:
     return value("Preferences/DynDNS/Password").toString();
   }
 
-  void setDynDNSPassword(const QString password) {
+  void setDynDNSPassword(const QString &password) {
     setValue("Preferences/DynDNS/Password", password);
   }
 

src/statsdialog.cpp

@@ -85,7 +85,7 @@ void StatsDialog::updateUI() {
   // num_peers is not reliable (adds up peers, which didn't even overcome tcp handshake)
   const std::vector<libtorrent::torrent_handle> torrents = session->getTorrents();
   std::vector<libtorrent::torrent_handle>::const_iterator iBegin = torrents.begin();
-  std::vector<libtorrent::torrent_handle>::const_iterator iEnd = torrents.begin();
+  std::vector<libtorrent::torrent_handle>::const_iterator iEnd = torrents.end();
   quint32 peers = 0;
   for ( ; iBegin < iEnd ; ++iBegin)
     peers += (*iBegin).status().num_peers;