YGGverse/xash3d-fwgs
1
0
Fork 0
mirror of https://github.com/YGGverse/xash3d-fwgs.git synced 2025-01-29 08:14:15 +00:00
Code Issues Projects Releases Wiki Activity

engine: client: restrict LOCALONLY cvars regardless of cl_filterstuffcmd value

Browse Source
This commit is contained in:
Alibek Omarov 2021-11-02 21:17:39 +06:00 committed by a1batross
parent 8a9231628e
commit c96f10d40b
2 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
engine/client/cl_game.c
View File

@ -1754,8 +1754,17 @@ static int GAME_EXPORT pfnFilteredClientCmd( const char *szCmdString )
if( !COM_CheckString( szCmdString )) if( !COM_CheckString( szCmdString ))
return 0; return 0;
// a1ba:
// there should be stufftext validator, that checks
// hardcoded commands and disallows them before passing to
// filtered buffer, returning 0
// I've replaced it by hooking potentially exploitable
// commands and variables(motd_write, motdfile, etc) in client interfaces
Cbuf_AddFilteredText( szCmdString ); Cbuf_AddFilteredText( szCmdString );
Cbuf_AddFilteredText( "\n" ); Cbuf_AddFilteredText( "\n" );
return 1;
} }
/* /*

13
engine/common/cvar.c
View File

@ -769,21 +769,12 @@ static qboolean Cvar_ShouldSetCvar( convar_t *v, qboolean isPrivileged )
if( isPrivileged ) if( isPrivileged )
return true; return true;
// TODO: figure this out if( v->flags & FCVAR_LOCALONLY )
//if( v->flags & FCVAR_SERVER ) return false;
// return false;
if( cl_filterstuffcmd.value <= 0.0f ) if( cl_filterstuffcmd.value <= 0.0f )
return true; return true;
// TODO: figure this out too
//if( v->flags & FCVAR_EXTDLL )
// return false;
// a1ba: xash3d-fwgs extension
if( v->flags & FCVAR_LOCALONLY )
return false;
for( i = 0; i < ARRAYSIZE( prefixes ); i++ ) for( i = 0; i < ARRAYSIZE( prefixes ); i++ )
{ {
if( Q_stricmp( v->name, prefixes[i] )) if( Q_stricmp( v->name, prefixes[i] ))