From a8f7b4fc5c813ee8d4896390672cedc604d99763 Mon Sep 17 00:00:00 2001 From: Alibek Omarov Date: Sun, 30 Jun 2019 17:26:57 +0300 Subject: [PATCH] win32: lib: remove unused variable, fix error message may be not printed --- engine/platform/win32/lib_win.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/engine/platform/win32/lib_win.c b/engine/platform/win32/lib_win.c index 1a553ce2..84f2de27 100644 --- a/engine/platform/win32/lib_win.c +++ b/engine/platform/win32/lib_win.c @@ -953,7 +953,6 @@ table_error: qboolean COM_CheckLibraryDirectDependency( const char *name, const char *depname, qboolean directpath ) { - MEMORYMODULE *result = NULL; PIMAGE_DOS_HEADER dos_header; PIMAGE_NT_HEADERS old_header; PIMAGE_DATA_DIRECTORY directory; @@ -972,7 +971,7 @@ qboolean COM_CheckLibraryDirectDependency( const char *name, const char *depname if( !data ) { Q_snprintf( errorstring, sizeof( errorstring ), "couldn't load %s", name ); - return false; + goto libraryerror; } dos_header = ( PIMAGE_DOS_HEADER )data; @@ -1013,7 +1012,7 @@ qboolean COM_CheckLibraryDirectDependency( const char *name, const char *depname libraryerror: Con_Printf( errorstring ); - Mem_Free( data ); // release memory + if( data ) Mem_Free( data ); // release memory return false; }