YGGverse/xash3d-fwgs
1
0
Fork 0
mirror of https://github.com/YGGverse/xash3d-fwgs.git synced 2025-01-30 08:44:31 +00:00
Code Issues Projects Releases Wiki Activity

engine: client: protect protected, privileged and server only cvars from server query

Browse Source
This commit is contained in:
Alibek Omarov 2021-11-07 13:33:21 +03:00 committed by a1batross
parent f2a9f805b8
commit 06eb6838a9
1 changed files with 28 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
engine/client/cl_parse.c
View File

@ -1883,46 +1883,42 @@ Find the client cvar value
and sent it back to the server and sent it back to the server
============== ==============
*/ */
void CL_ParseCvarValue( sizebuf_t *msg ) void CL_ParseCvarValue( sizebuf_t *msg, const qboolean ext )
{ {
const char *cvarName = MSG_ReadString( msg ); const char *cvarName, *response;
convar_t *cvar = Cvar_FindVar( cvarName ); convar_t *cvar;
int requestID;
// build the answer if( ext )
MSG_BeginClientCmd( &cls.netchan.message, clc_requestcvarvalue ); requestID = MSG_ReadLong( msg );
MSG_WriteString( &cls.netchan.message, cvar ? cvar->string : "Not Found" );
}
/* cvarName = MSG_ReadString( msg );
============== cvar = Cvar_FindVar( cvarName );
CL_ParseCvarValue2
Find the client cvar value
and sent it back to the server
==============
*/
void CL_ParseCvarValue2( sizebuf_t *msg )
{
int requestID = MSG_ReadLong( msg );
const char *cvarName = MSG_ReadString( msg );
convar_t *cvar = Cvar_FindVar( cvarName );
// build the answer
MSG_BeginClientCmd( &cls.netchan.message, clc_requestcvarvalue2 );
MSG_WriteLong( &cls.netchan.message, requestID );
MSG_WriteString( &cls.netchan.message, cvarName );
if( cvar ) if( cvar )
{ {
// cheater can change value ignoring Cvar_Set so we responce incorrect value if( cvar->flags & FCVAR_PRIVILEGED )
if( cvar->value != Q_atof( cvar->string )) response = "CVAR is privileged";
MSG_WriteString( &cls.netchan.message, va( "%s (%g)", cvar->string, cvar->value )); else if( cvar->flags & FCVAR_SERVER )
else MSG_WriteString( &cls.netchan.message, cvar->string ); response = "CVAR is server-only";
else if( cvar->flags & FCVAR_PROTECTED )
response = "CVAR is protected";
else
response = cvar->string;
}
else response = "Bad CVAR request";
if( ext )
{
MSG_BeginClientCmd( &cls.netchan.message, clc_requestcvarvalue2 );
MSG_WriteLong( &cls.netchan.message, requestID );
MSG_WriteString( &cls.netchan.message, cvarName );
} }
else else
{ {
MSG_WriteString( &cls.netchan.message, "Not Found" ); MSG_BeginClientCmd( &cls.netchan.message, clc_requestcvarvalue );
} }
MSG_WriteString( &cls.netchan.message, response );
} }
/* /*
@ -2376,10 +2372,10 @@ void CL_ParseServerMessage( sizebuf_t *msg, qboolean normal_message )
CL_ParseResLocation( msg ); CL_ParseResLocation( msg );
break; break;
case svc_querycvarvalue: case svc_querycvarvalue:
CL_ParseCvarValue( msg ); CL_ParseCvarValue( msg, false );
break; break;
case svc_querycvarvalue2: case svc_querycvarvalue2:
CL_ParseCvarValue2( msg ); CL_ParseCvarValue( msg, true );
break; break;
case svc_exec: case svc_exec:
CL_ParseExec( msg ); CL_ParseExec( msg );