From 48ad344adc8248fea94ee28bb18a37d6a2e9c8f2 Mon Sep 17 00:00:00 2001 From: yggverse Date: Fri, 22 Nov 2024 14:52:45 +0200 Subject: [PATCH] apply clippy optimizations --- .../window/tab/item/identity/gemini/widget/form.rs | 10 ++-------- .../tab/item/identity/gemini/widget/form/file.rs | 2 +- src/profile/identity/gemini/auth/memory.rs | 5 +---- 3 files changed, 4 insertions(+), 13 deletions(-) diff --git a/src/app/browser/window/tab/item/identity/gemini/widget/form.rs b/src/app/browser/window/tab/item/identity/gemini/widget/form.rs index aba4f35f..bce08ad2 100644 --- a/src/app/browser/window/tab/item/identity/gemini/widget/form.rs +++ b/src/app/browser/window/tab/item/identity/gemini/widget/form.rs @@ -42,16 +42,10 @@ impl Form { let update = action.update.clone(); move |item| { // Change name entry visibility - name.show(match item { - Value::GenerateNewAuth => true, - _ => false, - }); + name.show(matches!(item, Value::GenerateNewAuth)); // Change file choose button visibility - file.show(match item { - Value::ImportPem => true, - _ => false, - }); + file.show(matches!(item, Value::ImportPem)); // Update widget update.activate(); diff --git a/src/app/browser/window/tab/item/identity/gemini/widget/form/file.rs b/src/app/browser/window/tab/item/identity/gemini/widget/form/file.rs index ec6538ea..d485ce63 100644 --- a/src/app/browser/window/tab/item/identity/gemini/widget/form/file.rs +++ b/src/app/browser/window/tab/item/identity/gemini/widget/form/file.rs @@ -67,7 +67,7 @@ impl File { Ok(file) => match file.path() { Some(path) => { let filename = path.to_str().unwrap(); - match TlsCertificate::from_file(&filename) { + match TlsCertificate::from_file(filename) { Ok(certificate) => { pem.replace(to_pem(certificate)); gobject.set_css_classes(&["success"]); diff --git a/src/profile/identity/gemini/auth/memory.rs b/src/profile/identity/gemini/auth/memory.rs index e9ef386d..374d6dc1 100644 --- a/src/profile/identity/gemini/auth/memory.rs +++ b/src/profile/identity/gemini/auth/memory.rs @@ -55,9 +55,6 @@ impl Memory { result.sort_by(|a, b| b.1.cmp(&a.1)); // Get first match ID - match result.get(0) { - Some(value) => Some(value.0), - None => None, - } + result.first().map(|value| value.0) } }