YGGverse/Yoda
1
0
Fork 0
mirror of https://github.com/YGGverse/Yoda.git synced 2025-01-30 13:04:13 +00:00
Code Issues Projects Releases Wiki Activity

Revert "make tab widgets managed"

Browse Source 
This reverts commit 6dcfb669bfa3b7b60d9a6126bcddb2df3c23549a.
This commit is contained in:
yggverse 2024-09-02 19:21:13 +03:00
parent 6dcfb669bf
commit 468e582401
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/app/browser/main/tab.cpp
View File

@ -23,6 +23,8 @@ Tab::Tab()
); );
} }
Tab::~Tab() = default;
// Getters // Getters
Glib::ustring Tab::get_page_title( Glib::ustring Tab::get_page_title(
const int & PAGE_NUMBER const int & PAGE_NUMBER
@ -42,12 +44,12 @@ void Tab::append(
const Glib::ustring & REQUEST, const Glib::ustring & REQUEST,
const bool & FOCUS const bool & FOCUS
) { ) {
auto tabPage = Gtk::make_managed<tab::Page>( auto tabPage = new tab::Page(
TITLE, TITLE,
REQUEST REQUEST
); );
auto tabLabel = Gtk::make_managed<tab::Label>( auto tabLabel = new tab::Label(
TITLE TITLE
); );
@ -76,6 +78,7 @@ void Tab::close(
PAGE_NUMBER PAGE_NUMBER
); );
// @TODO memory cleanup
// @TODO fix GtkGizmo reported min height, but sizes must be >= 0 // @TODO fix GtkGizmo reported min height, but sizes must be >= 0
} }

3
src/app/browser/main/tab.hpp
View File

@ -4,7 +4,6 @@
#include <glibmm/i18n.h> #include <glibmm/i18n.h>
#include <glibmm/ustring.h> #include <glibmm/ustring.h>
#include <gtkmm/notebook.h> #include <gtkmm/notebook.h>
#include <gtkmm/object.h>
namespace app::browser::main namespace app::browser::main
{ {
@ -31,6 +30,8 @@ namespace app::browser::main
Tab(); Tab();
~Tab();
Glib::ustring get_page_title( Glib::ustring get_page_title(
const int & PAGE_NUMBER const int & PAGE_NUMBER
); );