Browse Source

rename deletePage to closePage, remove gtk node on apply

PHP-GTK3
yggverse 4 months ago
parent
commit
3d48e20809
  1. 11
      src/Entity/Browser/Container/Tab.php
  2. 2
      src/Entity/Browser/Menu/Tab/Close.php

11
src/Entity/Browser/Container/Tab.php

@ -72,7 +72,7 @@ class Tab @@ -72,7 +72,7 @@ class Tab
?\GtkWidget $child,
int $page_num
) {
$this->deletePage(
$this->closePage(
$page_num
);
}
@ -152,7 +152,7 @@ class Tab @@ -152,7 +152,7 @@ class Tab
return $this->_page[$page_num];
}
public function deletePage(
public function closePage(
int $page_num
): void
{
@ -161,10 +161,15 @@ class Tab @@ -161,10 +161,15 @@ class Tab
throw new \Exception;
}
// Remove GTK node
$this->gtk->remove_page(
$page_num
);
// Free memory
$this->_page[$page_num] = null;
// Remove internal record
// Cleanup internal record
unset(
$this->_page[$page_num]
);

2
src/Entity/Browser/Menu/Tab/Close.php

@ -33,7 +33,7 @@ class Close @@ -33,7 +33,7 @@ class Close
'activate',
function()
{
$this->tab->menu->browser->container->tab->gtk->remove_page(
$this->tab->menu->browser->container->tab->closePage(
$this->tab->menu->browser->container->tab->gtk->get_current_page()
);

Loading…
Cancel
Save