From b25cc173c53d26f62f9b4457727f79fdc1fadbe6 Mon Sep 17 00:00:00 2001 From: ghost Date: Mon, 9 Oct 2023 22:58:55 +0300 Subject: [PATCH] remove torrent file limits --- .env | 2 -- config/services.yaml | 2 -- src/Controller/PageController.php | 52 ++++++++++--------------------- 3 files changed, 16 insertions(+), 40 deletions(-) diff --git a/.env b/.env index 0188510..f612c84 100644 --- a/.env +++ b/.env @@ -63,6 +63,4 @@ APP_PAGE_TITLE_LENGTH_MIN=10 APP_PAGE_TITLE_LENGTH_MAX=255 APP_PAGE_DESCRIPTION_LENGTH_MIN=0 APP_PAGE_DESCRIPTION_LENGTH_MAX=10000 -APP_PAGE_TORRENT_FILE_QUANTITY_MIN=1 -APP_PAGE_TORRENT_FILE_QUANTITY_MAX=100 APP_TORRENT_FILE_SIZE_MAX=1024000 \ No newline at end of file diff --git a/config/services.yaml b/config/services.yaml index 36a739d..5b29831 100644 --- a/config/services.yaml +++ b/config/services.yaml @@ -16,8 +16,6 @@ parameters: app.page.title.length.max: '%env(APP_PAGE_TITLE_LENGTH_MAX)%' app.page.description.length.min: '%env(APP_PAGE_DESCRIPTION_LENGTH_MIN)%' app.page.description.length.max: '%env(APP_PAGE_DESCRIPTION_LENGTH_MAX)%' - app.page.torrent.file.quantity.min: '%env(APP_PAGE_TORRENT_FILE_QUANTITY_MIN)%' - app.page.torrent.file.quantity.max: '%env(APP_PAGE_TORRENT_FILE_QUANTITY_MAX)%' app.torrent.size.max: '%env(APP_TORRENT_FILE_SIZE_MAX)%' services: diff --git a/src/Controller/PageController.php b/src/Controller/PageController.php index a30785d..b913eb8 100644 --- a/src/Controller/PageController.php +++ b/src/Controller/PageController.php @@ -120,11 +120,7 @@ class PageController extends AbstractController 'error' => [], 'attribute' => [ - 'placeholder' => sprintf( - $translator->trans('Append %s-%s torrent files'), - $this->getParameter('app.page.torrent.file.quantity.min'), - $this->getParameter('app.page.torrent.file.quantity.max') - ) + 'placeholder' => $translator->trans('Select torrent file') ] ], 'sensitive' => @@ -170,35 +166,30 @@ class PageController extends AbstractController } /// Torrents - $total = 0; $torrents = []; if ($files = $request->files->get('torrents')) { foreach ($files as $file) { - //// Quantity - $total++; - - //// File size - if (filesize($file->getPathName()) > $this->getParameter('app.torrent.size.max')) + /// Torrent + if ($file = $request->files->get('torrent')) { - $form['torrents']['error'][] = $translator->trans('Torrent file out of size limit'); + //// Validate torrent file + if (filesize($file->getPathName()) > $this->getParameter('app.torrent.size.max')) + { + $form['torrents']['error'][] = $translator->trans('Torrent file out of size limit'); - continue; - } + continue; + } - //// Validate torrent format - try - { - \Rhilip\Bencode\TorrentFile::load( - $file->getPathName() - ); - } + //// Validate torrent format + if (!$torrentService->readTorrentFileByFilepath($file->getPathName())) + { + $form['torrents']['error'][] = $translator->trans('Could not parse torrent file'); - catch (ParseException $e) - { - $form['torrents']['error'][] = $translator->trans('Could not parse torrent file'); + continue; + } } //// Content @@ -206,7 +197,7 @@ class PageController extends AbstractController $file->getPathName(), $user->getId(), time(), - (array) $locales, + [$request->get('locale')], (bool) $request->get('sensitive'), $user->isApproved() ); @@ -215,17 +206,6 @@ class PageController extends AbstractController } } - if ($total < $this->getParameter('app.page.torrent.file.quantity.min') || - $total > $this->getParameter('app.page.torrent.file.quantity.max')) - { - $form['torrents']['error'][] = sprintf( - $translator->trans('Torrents quantity out of %s-%s range'), - number_format($this->getParameter('app.page.torrent.file.quantity.min')), - number_format($this->getParameter('app.page.torrent.file.quantity.max')) - ); - } - - if (empty($form['locale']['error']) && empty($form['title']['error']) && empty($form['description']['error']) &&