handle stream close depending on state

Streaming.cpp

@@ -35,6 +35,12 @@ namespace stream
 
 	Stream::~Stream ()
 	{	
+		Terminate ();
+		LogPrint (eLogDebug, "Stream deleted");
+	}	
+
+	void Stream::Terminate ()
+	{
 		m_AckSendTimer.cancel ();
 		while (!m_ReceiveQueue.empty ())
 		{
@@ -52,7 +58,6 @@ namespace stream
 		for (auto it: m_SavedPackets)
 			delete it;
 		m_SavedPackets.clear ();
-		LogPrint (eLogDebug, "Stream deleted");
 	}	
 		
 	void Stream::HandleNextPacket (Packet * packet)
@@ -438,23 +443,34 @@ namespace stream
 
 	void Stream::Close ()
 	{
-		if (m_Status == eStreamStatusOpen)
+		switch (m_Status)
-		{	
+		{
-			m_Status = eStreamStatusClosing;
+			case eStreamStatusOpen:
-			if (m_SendBuffer.eof ()) // nothing to send
+				m_Status = eStreamStatusClosing;
-				SendClose ();
+				Close (); // recursion
-		}	
+				if (m_Status == eStreamStatusClosing) //still closing
-		if (m_Status == eStreamStatusReset || m_SentPackets.empty ()) 
+					LogPrint (eLogInfo, "Trying to send stream data before closing");
-		{	
+			break;
-			// closed by peer or everything has been acknowledged
+			case eStreamStatusReset:
-			if (m_Status == eStreamStatusClosing)
+				Terminate ();
-				SendClose ();
+				m_LocalDestination.DeleteStream (shared_from_this ());	
-			m_ReceiveTimer.cancel ();
+			break;
-			m_LocalDestination.DeleteStream (shared_from_this ());	
+			case eStreamStatusClosing:
-		}	
+				if (m_SentPackets.empty () && m_SendBuffer.eof ()) // nothing to send
-		else
+				{
-			LogPrint (eLogInfo, "Trying to send stream data before closing");
+					SendClose ();
-			
+					Terminate ();
+					m_LocalDestination.DeleteStream (shared_from_this ());	
+				}
+			break;
+			case eStreamStatusClosed:
+				// already closed
+				Terminate ();
+				m_LocalDestination.DeleteStream (shared_from_this ());		
+			break;				
+			default:
+				LogPrint (eLogWarning, "Unexpected stream status ", (int)m_Status);
+		};			
 	}
 
 	void Stream::SendClose ()

Streaming.h

@@ -131,6 +131,8 @@ namespace stream
 			
 		private:
 
+			void Terminate ();
+
 			void SendBuffer ();
 			void SendQuickAck ();
 			void SendClose ();