From b5aa67b491ab3d283165dc3e64dee71e1cf99bb0 Mon Sep 17 00:00:00 2001 From: kote Date: Tue, 27 Aug 2019 17:10:53 +0800 Subject: [PATCH 1/4] tweaked debug logging in i2pd_qt --- qt/i2pd_qt/DaemonQT.cpp | 12 ++++++++++-- qt/i2pd_qt/logviewermanager.cpp | 2 +- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/qt/i2pd_qt/DaemonQT.cpp b/qt/i2pd_qt/DaemonQT.cpp index f5e6d62b..1e45c583 100644 --- a/qt/i2pd_qt/DaemonQT.cpp +++ b/qt/i2pd_qt/DaemonQT.cpp @@ -11,6 +11,8 @@ #include #include +//#define DEBUG_WITH_DEFAULT_LOGGING (1) + namespace i2p { namespace qt @@ -151,10 +153,16 @@ namespace qt int result; { - std::shared_ptr logstreamptr=std::make_shared(); + std::shared_ptr logstreamptr= +#ifdef DEBUG_WITH_DEFAULT_LOGGING + nullptr +#else + std::make_shared() +#endif + ; //TODO move daemon init deinit to a bg thread DaemonQTImpl daemon; - (*logstreamptr) << "Initialising the daemon..." << std::endl; + if(logstreamptr) (*logstreamptr) << "Initialising the daemon..." << std::endl; bool daemonInitSuccess = daemon.init(argc, argv, logstreamptr); if(!daemonInitSuccess) { diff --git a/qt/i2pd_qt/logviewermanager.cpp b/qt/i2pd_qt/logviewermanager.cpp index 30fc904a..823956b2 100644 --- a/qt/i2pd_qt/logviewermanager.cpp +++ b/qt/i2pd_qt/logviewermanager.cpp @@ -18,7 +18,7 @@ namespace logviewer { QString Worker::pollAndShootATimerForInfiniteRetries() { std::shared_ptr logStream=logViewerManager.getLogStream(); - assert(logStream!=nullptr); + if(!logStream)return ""; std::streamsize MAX_SZ=64*1024; char*buf=(char*)malloc(MAX_SZ*sizeof(char)); if(buf==nullptr)return ""; From 3939ca9eb48e34a82e72f30ee5162df3874dc57c Mon Sep 17 00:00:00 2001 From: kote Date: Tue, 27 Aug 2019 17:51:55 +0800 Subject: [PATCH 2/4] enabled default logging debug option for qt debug builds --- qt/i2pd_qt/i2pd_qt.pro | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qt/i2pd_qt/i2pd_qt.pro b/qt/i2pd_qt/i2pd_qt.pro index 9a978731..deb1c805 100644 --- a/qt/i2pd_qt/i2pd_qt.pro +++ b/qt/i2pd_qt/i2pd_qt.pro @@ -7,6 +7,8 @@ TEMPLATE = app QMAKE_CXXFLAGS *= -std=c++11 -Wno-unused-parameter -Wno-maybe-uninitialized DEFINES += USE_UPNP +debug: DEFINES += DEBUG_WITH_DEFAULT_LOGGING + SOURCES += DaemonQT.cpp mainwindow.cpp \ ../../libi2pd/api.cpp \ ../../libi2pd/Base.cpp \ From 99116ff097a87dcc32ecb978953dc807c2677f66 Mon Sep 17 00:00:00 2001 From: kote Date: Tue, 27 Aug 2019 19:31:28 +0800 Subject: [PATCH 3/4] qt: disabled upnp for now - until upnp fixed --- qt/i2pd_qt/i2pd_qt.pro | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qt/i2pd_qt/i2pd_qt.pro b/qt/i2pd_qt/i2pd_qt.pro index deb1c805..51aa4246 100644 --- a/qt/i2pd_qt/i2pd_qt.pro +++ b/qt/i2pd_qt/i2pd_qt.pro @@ -5,7 +5,10 @@ greaterThan(QT_MAJOR_VERSION, 4): QT += widgets TARGET = i2pd_qt TEMPLATE = app QMAKE_CXXFLAGS *= -std=c++11 -Wno-unused-parameter -Wno-maybe-uninitialized -DEFINES += USE_UPNP + +# For now, disable UPnP which currently crashes on Stop() -- https://github.com/PurpleI2P/i2pd/issues/1387 +#DEFINES += USE_UPNP +DEFINES -= USE_UPNP debug: DEFINES += DEBUG_WITH_DEFAULT_LOGGING From d523f0caddd3b743da91d19638564e2843935c93 Mon Sep 17 00:00:00 2001 From: kote Date: Tue, 27 Aug 2019 19:31:57 +0800 Subject: [PATCH 4/4] gitignored autosave files by qtcreator --- qt/i2pd_qt/.gitignore | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qt/i2pd_qt/.gitignore b/qt/i2pd_qt/.gitignore index 3abca1bd..f1d57c58 100644 --- a/qt/i2pd_qt/.gitignore +++ b/qt/i2pd_qt/.gitignore @@ -6,4 +6,6 @@ i2pd_qt Makefile* *.stash object_script.* -i2pd_qt_plugin_import.cpp \ No newline at end of file +i2pd_qt_plugin_import.cpp +i2pd_qt.pro.autosave* +