From 9897a49e1ad42c7a44205cc0c01813bd91c93f8c Mon Sep 17 00:00:00 2001
From: Meeh <meeh@i2pmail.org>
Date: Sat, 8 Feb 2014 03:15:08 +0100
Subject: [PATCH 1/2] Rewrite the thread stop in Queue

---
 Queue.h | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Queue.h b/Queue.h
index 449ff806..316084a9 100644
--- a/Queue.h
+++ b/Queue.h
@@ -98,17 +98,18 @@ namespace util
 	{
 		public:
 
-			MsgQueue (): m_Thread (std::bind (&MsgQueue<Msg>::Run, this)) {};
+			MsgQueue (): m_Thread (std::bind (&MsgQueue<Msg>::Run, this)) , running(1) {};
 			void Stop()
 			{
-					m_Thread.detach();
+				running = 0;
+				m_Thread.join();
 			}
 
 		private:
 			void Run ()
 			{
 				Msg * msg = nullptr;
-				while ((msg = Queue<Msg>::GetNext ()) != nullptr)
+				while ((msg = Queue<Msg>::GetNext ()) != nullptr && running)
 				{
 					msg->Process ();
 					delete msg;
@@ -117,6 +118,7 @@ namespace util
 			
 		private:
 			std::thread m_Thread;
+			int running;
 	};	
 }		
 }	

From 9b1e7956cb8b897628960e721571ce7c69bdfe1d Mon Sep 17 00:00:00 2001
From: Meeh <meeh@i2pmail.org>
Date: Sat, 8 Feb 2014 03:16:52 +0100
Subject: [PATCH 2/2] defining vars should cost less than function calls

---
 i2p.cpp | 32 ++++++++++++++++++--------------
 1 file changed, 18 insertions(+), 14 deletions(-)

diff --git a/i2p.cpp b/i2p.cpp
index 355c2003..97914b5e 100644
--- a/i2p.cpp
+++ b/i2p.cpp
@@ -27,6 +27,7 @@
 
 // Global
 int running = 1;
+int isDaemon;
 
 #ifndef _WIN32
 void handle_signal(int sig)
@@ -59,6 +60,7 @@ void handle_signal(int sig)
 int main( int argc, char* argv[] )
 {
   i2p::util::config::OptionParser(argc,argv);
+  isDaemon = i2p::util::config::GetArg("-daemon", 0);
 #ifdef _WIN32
   setlocale(LC_CTYPE, "");
   SetConsoleCP(1251);
@@ -71,8 +73,22 @@ int main( int argc, char* argv[] )
   LogPrint("data directory: ", i2p::util::filesystem::GetDataDir().string());
   i2p::util::filesystem::ReadConfigFile(i2p::util::config::mapArgs, i2p::util::config::mapMultiArgs);
 
+  int isLogging = i2p::util::config::GetArg("-log", 0);
+  if (isLogging == 1)
+  {
+    std::string logfile = i2p::util::filesystem::GetDataDir().string();
+#ifndef _WIN32
+    logfile.append("/debug.log");
+#else
+    logfile.append("\\debug.log");
+#endif
+    freopen(logfile.c_str(),"a",stdout);
+    LogPrint("Logging to file enabled.");
+  }
+
+
 #ifndef _WIN32
-  if (i2p::util::config::GetArg("-daemon", 0) == 1)
+  if (isDaemon == 1)
   {
     pid_t pid;
     pid = fork();
@@ -125,18 +141,6 @@ int main( int argc, char* argv[] )
   sigaction(SIGINT,&sa,0);
 #endif
 
-  if (i2p::util::config::GetArg("-log", 0) == 1)
-  {
-    std::string logfile = i2p::util::filesystem::GetDataDir().string();
-#ifndef _WIN32
-    logfile.append("/debug.log");
-#else
-    logfile.append("\\debug.log");
-#endif
-    LogPrint("Logging to file enabled.");
-    freopen(logfile.c_str(),"a",stdout);
-  }
-
   //TODO: This is an ugly workaround. fix it.
   //TODO: Autodetect public IP.
   i2p::context.OverrideNTCPAddress(i2p::util::config::GetCharArg("-host", "127.0.0.1"),
@@ -161,7 +165,7 @@ int main( int argc, char* argv[] )
   i2p::data::netdb.Stop ();
   httpServer.Stop ();
 
-  if (i2p::util::config::GetArg("-log", 0) == 1)
+  if (isLogging == 1)
   {
     fclose (stdout);
   }