invoke win32app functions from main

Daemon.h

@@ -48,9 +48,10 @@ namespace i2p
 				return instance;
 			}
 
-			virtual bool init(int argc, char* argv[]);
+			bool init(int argc, char* argv[]);
-			virtual bool start();
+			bool start();
-			virtual bool stop();
+			bool stop();
+			void run ();
 		};
 #else
 		class DaemonLinux : public Daemon_Singleton

DaemonWin32.cpp

@@ -5,7 +5,7 @@
 
 #ifdef _WIN32
 
-#include "./Win32/Win32Service.h"
+#include "Win32/Win32App.h"
 
 namespace i2p
 {
@@ -17,56 +17,16 @@ namespace i2p
 			SetConsoleCP(1251);
 			SetConsoleOutputCP(1251);
 			setlocale(LC_ALL, "Russian");
-
+            return Daemon_Singleton::init(argc, argv);
-			if (!Daemon_Singleton::init(argc, argv)) return false;
-			if (I2PService::isService())
-				isDaemon = 1;
-			else
-				isDaemon = 0;
-
-			std::string serviceControl; i2p::config::GetOption("svcctl", serviceControl);
-			if (serviceControl == "install")
-			{
-				LogPrint(eLogInfo, "WinSVC: installing ", SERVICE_NAME, " as service");
-				InstallService(
-					SERVICE_NAME,               // Name of service
-					SERVICE_DISPLAY_NAME,       // Name to display
-					SERVICE_START_TYPE,         // Service start type
-					SERVICE_DEPENDENCIES,       // Dependencies
-					SERVICE_ACCOUNT,            // Service running account
-					SERVICE_PASSWORD            // Password of the account
-					);
-				exit(0);
-			}
-			else if (serviceControl == "remove")
-			{
-				LogPrint(eLogInfo, "WinSVC: uninstalling ", SERVICE_NAME, " service");
-				UninstallService(SERVICE_NAME);
-				exit(0);
-			}
-			
-			if (isDaemon == 1)
-			{
-				LogPrint(eLogDebug, "Daemon: running as service");
-				I2PService service(SERVICE_NAME);
-				if (!I2PService::Run(service))
-				{
-					LogPrint(eLogError, "Daemon: Service failed to run w/err 0x%08lx\n", GetLastError());
-					exit(EXIT_FAILURE);
 		}
-				exit(EXIT_SUCCESS);
-			}
-			else
-				LogPrint(eLogDebug, "Daemon: running as user");
 
-			return true;
-		}
 		bool DaemonWin32::start()
 		{
 			setlocale(LC_CTYPE, "");
 			SetConsoleCP(1251);
 			SetConsoleOutputCP(1251);
 			setlocale(LC_ALL, "Russian");
+            if (!i2p::win32::StartWin32App ()) return false;
 
 			bool ret = Daemon_Singleton::start();
 			if (ret && IsLogToFile ())
@@ -80,8 +40,14 @@ namespace i2p
 
 		bool DaemonWin32::stop()
 		{
+		    i2p::win32::StopWin32App ();
 			return Daemon_Singleton::stop();
 		}
+
+		void DaemonWin32::run ()
+        {
+            i2p::win32::RunWin32App ();
+        }
 	}
 }
 

Makefile

@@ -22,7 +22,7 @@ else ifeq ($(UNAME),Linux)
 	DAEMON_SRC += DaemonLinux.cpp
 	include Makefile.linux
 else # win32 mingw
-	DAEMON_SRC += DaemonWin32.cpp Win32/Win32Service.cpp Win32/Win32App.cpp
+	DAEMON_SRC += DaemonWin32.cpp Win32/Win32App.cpp
 	include Makefile.mingw
 endif
 

Win32/Win32App.cpp

@@ -11,8 +11,12 @@
 #define ID_TRAY_ICON 2050
 #define WM_TRAYICON (WM_USER + 1)
 
-void ShowPopupMenu (HWND hWnd, POINT *curpos, int wDefaultItem)
+namespace i2p
 {
+namespace win32
+{
+    static void ShowPopupMenu (HWND hWnd, POINT *curpos, int wDefaultItem)
+    {
         HMENU hPopup = CreatePopupMenu();
         InsertMenu (hPopup, 0, MF_BYPOSITION | MF_STRING, ID_ABOUT, "About...");
         InsertMenu (hPopup, 1, MF_BYPOSITION | MF_STRING, ID_EXIT , "Exit");
@@ -31,10 +35,10 @@ void ShowPopupMenu (HWND hWnd, POINT *curpos, int wDefaultItem)
         SendMessage (hWnd, WM_COMMAND, cmd, 0);
 
         DestroyMenu(hPopup);
-}
+    }
 
-void AddTrayIcon (HWND hWnd)
+    static void AddTrayIcon (HWND hWnd)
-{
+    {
         NOTIFYICONDATA nid;
         memset(&nid, 0, sizeof(nid));
         nid.cbSize = sizeof(nid);
@@ -45,18 +49,18 @@ void AddTrayIcon (HWND hWnd)
         nid.hIcon = LoadIcon (GetModuleHandle(NULL), MAKEINTRESOURCE (IDI_ICON1));
         strcpy (nid.szTip, "i2pd");
         Shell_NotifyIcon(NIM_ADD, &nid );
-}
+    }
 
-void RemoveTrayIcon (HWND hWnd)
+    static void RemoveTrayIcon (HWND hWnd)
-{
+    {
         NOTIFYICONDATA nid;
         nid.hWnd = hWnd;
         nid.uID = ID_TRAY_ICON;
         Shell_NotifyIcon (NIM_DELETE, &nid);
-}
+    }
 
-static LRESULT CALLBACK WndProc (HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam)
+    static LRESULT CALLBACK WndProc (HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam)
-{
+    {
         switch (uMsg)
         {
             case WM_CREATE:
@@ -104,17 +108,17 @@ static LRESULT CALLBACK WndProc (HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lPa
             }
         }
         return DefWindowProc( hWnd, uMsg, wParam, lParam);
-}
+    }
 
- int WINAPI WinMain (HINSTANCE hInst, HINSTANCE prev, LPSTR cmdline, int show)
+    bool StartWin32App ()
     {
-    // check if tunning already
         if (FindWindow (I2PD_WIN32_CLASSNAME, TEXT("i2pd")))
         {
             MessageBox(NULL, TEXT("I2Pd is running already"), TEXT("Warning"), MB_OK);
-        return 0;
+            return false;
         }
         // register main window
+        auto hInst = GetModuleHandle(NULL);
         WNDCLASSEX wclx;
         memset (&wclx, 0, sizeof(wclx));
         wclx.cbSize = sizeof(wclx);
@@ -134,24 +138,25 @@ static LRESULT CALLBACK WndProc (HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lPa
         if (!CreateWindow(I2PD_WIN32_CLASSNAME, TEXT("i2pd"), WS_OVERLAPPEDWINDOW | WS_VISIBLE, 100, 100, 250, 150, NULL, NULL, hInst, NULL))
         {
             MessageBox(NULL, "Failed to create main window", TEXT("Warning!"), MB_ICONERROR | MB_OK | MB_TOPMOST);
-        return 1;
+            return false;
+        }
+        return true;
     }
 
-  /*  // init
+    int RunWin32App ()
-    char * argv[] = { (char *)"i2pd" };
+    {
-    Daemon.init(sizeof (argv)/sizeof (argv[0]), argv);
-    // start
-    Daemon.start ();*/
-    // main loop
         MSG msg;
         while (GetMessage (&msg, NULL, 0, 0 ))
         {
             TranslateMessage (&msg);
             DispatchMessage (&msg);
         }
-   /* // atop
-    Daemon.stop ();*/
-    // terminate
-    UnregisterClass (I2PD_WIN32_CLASSNAME, hInst);
         return msg.wParam;
     }
+
+    void StopWin32App ()
+    {
+         UnregisterClass (I2PD_WIN32_CLASSNAME, GetModuleHandle(NULL));
+    }
+}
+}

Win32/Win32App.h

@@ -3,4 +3,13 @@
 
 #define I2PD_WIN32_CLASSNAME "i2pd main window"
 
+namespace i2p
+{
+namespace win32
+{
+    bool StartWin32App ();
+    void StopWin32App ();
+    int RunWin32App ();
+}
+}
 #endif // WIN32APP_H__