From 1bbaa5ba2271a8dc8d8f3e0ded7c40817001029e Mon Sep 17 00:00:00 2001
From: "Francisco Blas (klondike) Izquierdo Riera" <klondike@klondike.es>
Date: Sat, 7 Feb 2015 18:34:25 +0100
Subject: [PATCH] URLdecode the base64 part of the key

---
 HTTPProxy.cpp |  2 ++
 util.cpp      | 11 +++++++++++
 util.h        |  1 +
 3 files changed, 14 insertions(+)

diff --git a/HTTPProxy.cpp b/HTTPProxy.cpp
index 7f6237f3..8f2a1654 100644
--- a/HTTPProxy.cpp
+++ b/HTTPProxy.cpp
@@ -5,6 +5,7 @@
 #include <string>
 #include <atomic>
 #include "HTTPProxy.h"
+#include "util.h"
 #include "Identity.h"
 #include "Streaming.h"
 #include "Destination.h"
@@ -148,6 +149,7 @@ namespace proxy
 				addressHelperPos = addressHelperPos2;
 		}
 		auto base64 = m_path.substr (addressHelperPos + strlen(helpermark1));
+		base64 = i2p::util::http::urlDecode(base64); //Some of the symbols may be urlencoded
 		LogPrint (eLogDebug,"Jump service for ", m_address, " found at ", base64, ". Inserting to address book");
 		//TODO: this is very dangerous and broken. We should ask the user before doing anything see http://pastethis.i2p/raw/pn5fL4YNJL7OSWj3Sc6N/
 		//TODO: we could redirect the user again to avoid dirtiness in the browser
diff --git a/util.cpp b/util.cpp
index cf5628f3..e3b4d894 100644
--- a/util.cpp
+++ b/util.cpp
@@ -1,3 +1,4 @@
+#include <cstdlib>
 #include <string>
 #include <algorithm>
 #include <cctype>
@@ -444,6 +445,16 @@ namespace http
 		query_.assign(query_i, url_s.end());
 	}
 
+	std::string urlDecode(const std::string& data)
+	{
+		std::string res(data);
+		for (size_t pos = res.find('%'); pos != std::string::npos; pos = res.find('%',pos+1))
+		{
+			char c = strtol(res.substr(pos+1,2).c_str(), NULL, 16);
+			res.replace(pos,3,1,c);
+		}
+		return res;
+	}
 } 
 
 namespace net
diff --git a/util.h b/util.h
index e07b746e..8aee0560 100644
--- a/util.h
+++ b/util.h
@@ -49,6 +49,7 @@ namespace util
 		std::string httpRequest(const std::string& address);
 		void MergeChunkedResponse (std::istream& response, std::ostream& merged);
 		int httpRequestViaI2pProxy(const std::string& address, std::string &content); // return http code
+		std::string urlDecode(const std::string& data);
 		
 		struct url {
     			url(const std::string& url_s); // omitted copy, ==, accessors, ...