GOSTSec/sgminer
1
0
Fork 0
mirror of https://github.com/GOSTSec/sgminer synced 2025-01-10 23:08:07 +00:00
Code Issues Releases Wiki Activity

stratum: parse_notify(): Don't die on malformed bbversion/prev_hash/nbit/ntime.

Browse Source 
Might have introduced a memory leak, don't have time to check. :(

Should the other hex2bin()'s be checked?

Thanks to Mick Ayzenberg <mick.dejavusecurity.com> for finding this.
This commit is contained in:
Noel Maersk 2014-06-05 23:02:02 +03:00
parent cab6e28b12
commit ae7dbca783
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
util.c
View File

@ -1599,17 +1599,23 @@ static bool parse_notify(struct pool *pool, json_t *val)
pool->swork.nbit, pool->swork.nbit,
"00000000", /* nonce */ "00000000", /* nonce */
workpadding); workpadding);
if (unlikely(!hex2bin(pool->header_bin, header, 128))) if (unlikely(!hex2bin(pool->header_bin, header, 128))) {
quit(1, "Failed to convert header to header_bin in parse_notify"); applog(LOG_WARNING, "%s: Failed to convert header to header_bin, got %s", __func__, header);
pool_failed(pool);
// TODO: memory leaks? goto out, clean up there?
return false;
}
cb1 = (unsigned char *)calloc(cb1_len, 1); cb1 = (unsigned char *)calloc(cb1_len, 1);
if (unlikely(!cb1)) if (unlikely(!cb1))
quithere(1, "Failed to calloc cb1 in parse_notify"); quithere(1, "Failed to calloc cb1 in parse_notify");
hex2bin(cb1, coinbase1, cb1_len); hex2bin(cb1, coinbase1, cb1_len);
cb2 = (unsigned char *)calloc(cb2_len, 1); cb2 = (unsigned char *)calloc(cb2_len, 1);
if (unlikely(!cb2)) if (unlikely(!cb2))
quithere(1, "Failed to calloc cb2 in parse_notify"); quithere(1, "Failed to calloc cb2 in parse_notify");
hex2bin(cb2, coinbase2, cb2_len); hex2bin(cb2, coinbase2, cb2_len);
free(pool->coinbase); free(pool->coinbase);
align_len(&alloc_len); align_len(&alloc_len);
pool->coinbase = (unsigned char *)calloc(alloc_len, 1); pool->coinbase = (unsigned char *)calloc(alloc_len, 1);
@ -1617,6 +1623,7 @@ static bool parse_notify(struct pool *pool, json_t *val)
quit(1, "Failed to calloc pool coinbase in parse_notify"); quit(1, "Failed to calloc pool coinbase in parse_notify");
memcpy(pool->coinbase, cb1, cb1_len); memcpy(pool->coinbase, cb1, cb1_len);
memcpy(pool->coinbase + cb1_len, pool->nonce1bin, pool->n1_len); memcpy(pool->coinbase + cb1_len, pool->nonce1bin, pool->n1_len);
// NOTE: gap for nonce2, filled at work generation time
memcpy(pool->coinbase + cb1_len + pool->n1_len + pool->n2size, cb2, cb2_len); memcpy(pool->coinbase + cb1_len + pool->n1_len + pool->n2size, cb2, cb2_len);
cg_wunlock(&pool->data_lock); cg_wunlock(&pool->data_lock);