From aa75d841425cfd9294d8e9314876ed5da0d727a8 Mon Sep 17 00:00:00 2001 From: Con Kolivas Date: Mon, 7 Oct 2013 19:50:38 +1100 Subject: [PATCH] Use libusb's own error name function instead of hand coding the error names. --- usbutils.c | 31 ++++--------------------------- 1 file changed, 4 insertions(+), 27 deletions(-) diff --git a/usbutils.c b/usbutils.c index da3435e8..e977e2ab 100644 --- a/usbutils.c +++ b/usbutils.c @@ -587,29 +587,6 @@ static const char *BULK = "Bulk"; static const char *INTERRUPT = "Interrupt"; static const char *UNKNOWN = "Unknown"; -static const char *err_io_str = " IO Error"; -static const char *err_access_str = " Access Denied-a"; -static const char *err_timeout_str = " Reply Timeout"; -static const char *err_pipe_str = " Access denied-p"; -static const char *err_other_str = " Access denied-o"; - -static const char *usberrstr(int err) -{ - switch (err) { - case LIBUSB_ERROR_IO: - return err_io_str; - case LIBUSB_ERROR_ACCESS: - return err_access_str; - case LIBUSB_ERROR_TIMEOUT: - return err_timeout_str; - case LIBUSB_ERROR_PIPE: - return err_pipe_str; - case LIBUSB_ERROR_OTHER: - return err_other_str; - } - return BLANK; -} - static const char *destype(uint8_t bDescriptorType) { switch (bDescriptorType) { @@ -816,11 +793,11 @@ static void usb_full(ssize_t *count, libusb_device *dev, char **buf, size_t *off err = libusb_get_string_descriptor_ascii(handle, desc.iManufacturer, man, STRBUFLEN); if (err < 0) - snprintf((char *)man, sizeof(man), "** err(%d)%s", err, usberrstr(err)); + snprintf((char *)man, sizeof(man), "** err(%d)%s", err, libusb_error_name(err)); err = libusb_get_string_descriptor_ascii(handle, desc.iProduct, prod, STRBUFLEN); if (err < 0) - snprintf((char *)prod, sizeof(prod), "** err(%d)%s", err, usberrstr(err)); + snprintf((char *)prod, sizeof(prod), "** err(%d)%s", err, libusb_error_name(err)); if (level == 0) { libusb_close(handle); @@ -896,7 +873,7 @@ static void usb_full(ssize_t *count, libusb_device *dev, char **buf, size_t *off err = libusb_get_string_descriptor_ascii(handle, desc.iSerialNumber, ser, STRBUFLEN); if (err < 0) - snprintf((char *)ser, sizeof(ser), "** err(%d)%s", err, usberrstr(err)); + snprintf((char *)ser, sizeof(ser), "** err(%d)%s", err, libusb_error_name(err)); snprintf(tmp, sizeof(tmp), EOL " dev %d: More Info:" EOL "\tManufacturer: '%s'" EOL "\tProduct: '%s'" EOL "\tSerial '%s'", @@ -916,7 +893,7 @@ void usb_all(int level) count = libusb_get_device_list(NULL, &list); if (count < 0) { - applog(LOG_ERR, "USB all: failed, err %d%s", (int)count, usberrstr((int)count)); + applog(LOG_ERR, "USB all: failed, err %d%s", (int)count, libusb_error_name((int)count)); return; }