From af758bb37cb571e0b3afa6b00c3d01c078357d2f Mon Sep 17 00:00:00 2001 From: Intel Date: Tue, 6 May 2014 15:21:32 -0400 Subject: [PATCH] Implemented MySQL reconnect --- .../shared/MySQL/DatabaseConnection.cpp | 34 ++++++++++++++++--- src/server/shared/MySQL/DatabaseConnection.h | 9 +++++ 2 files changed, 39 insertions(+), 4 deletions(-) diff --git a/src/server/shared/MySQL/DatabaseConnection.cpp b/src/server/shared/MySQL/DatabaseConnection.cpp index adc6dbc..84dc28d 100644 --- a/src/server/shared/MySQL/DatabaseConnection.cpp +++ b/src/server/shared/MySQL/DatabaseConnection.cpp @@ -26,7 +26,7 @@ namespace MySQL bool DatabaseConnection::Open() { - MYSQL* mysqlInit; + MYSQL* mysqlInit = NULL; mysqlInit = mysql_init(NULL); if (!mysqlInit) throw ConnectionException(Util::FS("Could not initialize Mysql connection to database `%s`", _connectionInfo.DB.c_str())); @@ -50,8 +50,11 @@ namespace MySQL else { const char* error = mysql_error(mysqlInit); + _mysqlConnectError = mysql_errno(mysqlInit); // Used for DatabaseConnection::_HandleMySQLErrno mysql_close(mysqlInit); - throw ConnectionException(Util::FS("Could not connect to MySQL database at %s: %s", _connectionInfo.Host.c_str(), mysql_error(mysqlInit))); + mysqlInit = NULL; + + throw ConnectionException(Util::FS("Could not connect to MySQL database at %s: %s", _connectionInfo.Host.c_str(), error)); } } @@ -285,8 +288,31 @@ namespace MySQL return true; } - bool DatabaseConnection::_HandleMySQLErrno(uint32_t lErrno) + bool DatabaseConnection::_HandleMySQLErrno(uint32 lErrno) { - return false; + switch (lErrno) + { + case CR_SERVER_GONE_ERROR: + case CR_SERVER_LOST: + case CR_INVALID_CONN_HANDLE: + case CR_SERVER_LOST_EXTENDED: + { + mysql_close(_mysql); + + try { + Open(); + return true; + } catch(std::exception& e) { + sLog.Error(LOG_DATABASE, "Failed to connect to mysql database: %s", e.what()); + + // It's possible this attempted reconnect throws 2006 at us. To prevent crazy recursive calls, sleep here. + boost::this_thread::sleep(boost::posix_time::milliseconds(3000)); + return _HandleMySQLErrno(_mysqlConnectError); + } + } + default: + sLog.Error(LOG_DATABASE, "Unhandled MySQL errno %u. Unexpected behaviour possible.", lErrno); + return false; + } } } diff --git a/src/server/shared/MySQL/DatabaseConnection.h b/src/server/shared/MySQL/DatabaseConnection.h index 08bedd8..7bac03f 100644 --- a/src/server/shared/MySQL/DatabaseConnection.h +++ b/src/server/shared/MySQL/DatabaseConnection.h @@ -14,6 +14,14 @@ namespace MySQL { + enum ClientError + { + CR_SERVER_GONE_ERROR = 2006, + CR_SERVER_LOST = 2013, + CR_INVALID_CONN_HANDLE = 2048, + CR_SERVER_LOST_EXTENDED = 2055 + }; + enum ConnectionType { MYSQL_CONN_SYNC, @@ -99,6 +107,7 @@ namespace MySQL boost::mutex _mutex; MYSQL* _mysql; + uint32 _mysqlConnectError; DatabaseWorkQueue* _asyncQueue; DatabaseWorker* _worker; std::vector _stmts;