correct serialization

src/netbase.cpp

@@ -1,6 +1,5 @@
 // Copyright (c) 2009-2010 Satoshi Nakamoto
 // Copyright (c) 2009-2012 The Bitcoin developers
-// Copyright (c) 2017-2018 The Gostcoin Developers
 // Distributed under the MIT/X11 software license, see the accompanying
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
@@ -581,13 +580,13 @@ bool ConnectSocketByName(CService &addr, SOCKET& hSocketRet, const char *pszDest
 void CNetAddr::Init()
 {
     memset(ip, 0, sizeof(ip));
-    i2pDest = "";
+    memset(i2pDest, 0, NATIVE_I2P_DESTINATION_SIZE);
 }
 
 void CNetAddr::SetIP(const CNetAddr& ipIn)
 {
     memcpy(ip, ipIn.ip, sizeof(ip));
-    i2pDest = ipIn.i2pDest;
+    memcpy(i2pDest, ipIn.i2pDest, NATIVE_I2P_DESTINATION_SIZE);
 }
 
 
@@ -596,15 +595,16 @@ bool CNetAddr::SetSpecial(const std::string &strName)
     const bool isBase32Addr = (strName.size() == NATIVE_I2P_B32ADDR_SIZE) && (strName.substr(strName.size() - 8, 8) == ".b32.i2p");
     const std::string addr = isBase32Addr ? I2PSession::Instance().namingLookup(strName) : strName;
 
-    if ((addr.length() == NATIVE_I2P_DESTINATION_SIZE))
+    if (addr.size() == NATIVE_I2P_DESTINATION_SIZE) 
-	{	
+    { 
-		auto trailer = addr.substr(addr.size() - 5, 5);
+        auto trailer = addr.substr(addr.size() - 5, 5);
-		if (trailer == "AAA==" || trailer == "AAQ==") 
+        if ((trailer == "AAA==") || (trailer == "AAQ=="))
-		{ // last 5 symbols of b64-destination must be AAA== (ElGamal) or AAQ== (ECIES)
+        {   
-		    i2pDest = addr;
+            // last 5 symbols of b64-destination must be AAA== (ElGamal) or AAQ== (ECIES)
-		    return true;
+            memcpy(i2pDest, addr.c_str(), NATIVE_I2P_DESTINATION_SIZE);
-		}
+            return true;
-	}
+        }
+    }
     return false;
 }
 
@@ -617,14 +617,14 @@ CNetAddr::CNetAddr(const struct in_addr& ipv4Addr)
 {
     memcpy(ip,    pchIPv4, 12);
     memcpy(ip+12, &ipv4Addr, 4);
-    i2pDest = "";
+    memset(i2pDest, 0, NATIVE_I2P_DESTINATION_SIZE);
 }
 
 #ifdef USE_IPV6
 CNetAddr::CNetAddr(const struct in6_addr& ipv6Addr)
 {
     memcpy(ip, &ipv6Addr, 16);
-    i2pDest = "";
+    memset(i2pDest, 0, NATIVE_I2P_DESTINATION_SIZE);
 }
 #endif
 
@@ -718,12 +718,12 @@ bool CNetAddr::IsRFC4843() const
 
 bool CNetAddr::IsNativeI2P() const
 {
-    return !i2pDest.empty ();
+    return i2pDest[0]; // nonzero
 }
 
 std::string CNetAddr::GetI2PDestination() const
 {
-    return i2pDest;
+    return std::string(i2pDest, i2pDest + NATIVE_I2P_DESTINATION_SIZE);
 }
 
 bool CNetAddr::IsLocal() const
@@ -838,17 +838,17 @@ std::string CNetAddr::ToString() const
 
 bool operator==(const CNetAddr& a, const CNetAddr& b)
 {
-    return (memcmp(a.ip, b.ip, 16) == 0 && a.i2pDest == b.i2pDest);
+    return (memcmp(a.ip, b.ip, 16) == 0 && memcmp(a.i2pDest, b.i2pDest, NATIVE_I2P_DESTINATION_SIZE) == 0);
 }
 
 bool operator!=(const CNetAddr& a, const CNetAddr& b)
 {
-    return (memcmp(a.ip, b.ip, 16) != 0 || a.i2pDest != b.i2pDest);
+    return (memcmp(a.ip, b.ip, 16) != 0 || memcmp(a.i2pDest, b.i2pDest, NATIVE_I2P_DESTINATION_SIZE) != 0);
 }
 
 bool operator<(const CNetAddr& a, const CNetAddr& b)
 {
-    return (memcmp(a.ip, b.ip, 16) < 0 || (memcmp(a.ip, b.ip, 16) == 0 && a.i2pDest < b.i2pDest));
+    return (memcmp(a.ip, b.ip, 16) < 0 || (memcmp(a.ip, b.ip, 16) == 0 && memcmp(a.i2pDest, b.i2pDest, NATIVE_I2P_DESTINATION_SIZE) < 0));
 }
 
 bool CNetAddr::GetInAddr(struct in_addr* pipv4Addr) const
@@ -880,9 +880,9 @@ std::vector<unsigned char> CNetAddr::GetGroup() const
 
     if (IsNativeI2P())
     {
-        vchRet.resize(i2pDest.length () + 1);
+        vchRet.resize(NATIVE_I2P_DESTINATION_SIZE + 1);
         vchRet[0] = NET_NATIVE_I2P;
-        memcpy(&vchRet[1], i2pDest.c_str (), i2pDest.length ());
+        memcpy(&vchRet[1], i2pDest, NATIVE_I2P_DESTINATION_SIZE);
         return vchRet;
     }
 
@@ -942,7 +942,7 @@ std::vector<unsigned char> CNetAddr::GetGroup() const
 
 uint64 CNetAddr::GetHash() const
 {
-    uint256 hash = IsNativeI2P() ? Hash(i2pDest.c_str (), i2pDest.c_str () + i2pDest.length ()) : Hash(&ip[0], &ip[16]);
+    uint256 hash = IsNativeI2P() ? Hash(i2pDest, i2pDest + NATIVE_I2P_DESTINATION_SIZE) : Hash(&ip[0], &ip[16]);
     uint64 nRet;
     memcpy(&nRet, &hash, sizeof(nRet));
     return nRet;
@@ -1164,8 +1164,8 @@ std::vector<unsigned char> CService::GetKey() const
      std::vector<unsigned char> vKey;
      if (IsNativeI2P())
      {
-         vKey.resize(i2pDest.length ());
+         vKey.resize(NATIVE_I2P_DESTINATION_SIZE);
-         memcpy(&vKey[0], i2pDest.c_str (), i2pDest.length ());
+         memcpy(&vKey[0], i2pDest, NATIVE_I2P_DESTINATION_SIZE);
          return vKey;
      }
      vKey.resize(18);

src/netbase.h

@@ -1,5 +1,4 @@
 // Copyright (c) 2009-2012 The Bitcoin developers
-// Copyright (c) 2017-2018 The Gostcoin Developers
 // Distributed under the MIT/X11 software license, see the accompanying
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 #ifndef BITCOIN_NETBASE_H
@@ -39,7 +38,7 @@ class CNetAddr
 {
     protected:
         unsigned char ip[16]; // in network byte order
-        std::string i2pDest; // I2P Destination
+        unsigned char i2pDest[NATIVE_I2P_DESTINATION_SIZE]; // I2P Destination (should be array for serialization)
 
     public:
         CNetAddr();
@@ -91,7 +90,7 @@ class CNetAddr
              READWRITE(FLATDATA(ip));
              if (!(nType & SER_IPADDRONLY))
              {
-                READWRITE(i2pDest);
+                READWRITE(FLATDATA(i2pDest));
              }
             )
 };
@@ -136,7 +135,7 @@ class CService : public CNetAddr
              READWRITE(FLATDATA(ip));
 	     if (!(nType & SER_IPADDRONLY))
 	     {
-	         READWRITE(i2pDest);
+	         READWRITE(FLATDATA(i2pDest));
 	     }
              unsigned short portN = htons(port);
              READWRITE(portN);